From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Shyti Date: Fri, 08 Feb 2013 12:48:30 +0000 Subject: Re: [PATCH 1/1] OMAP4: DSS: Add panel for Blaze Tablet boards Message-Id: <20130208124829.GB10564@jack.whiskey> List-Id: References: <1360248051-16541-1-git-send-email-ruslan.bilovol@ti.com> <1360248051-16541-2-git-send-email-ruslan.bilovol@ti.com> <20130207145952.GA7860@jack.whiskey> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ruslan Bilovol Cc: Andi Shyti , tomi.valkeinen@ti.com, FlorianSchandinat@gmx.de, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Hi, > Thanks for looking into if you want you can put me in CC and I can review the next patches (perhaps V2 of the patches) > >> + mutex_lock(&tc358765_i2c->xfer_lock); > >> + ret = i2c_transfer(tc358765_i2c->client->adapter, &msg, 1); > >> + mutex_unlock(&tc358765_i2c->xfer_lock); > > > > What about using smbus? > > OMAP2+ SoCs have full I2C controller so panel drivers traditionally use I2C. > Since implementation is OMAP-specific, I don't think we need to use smbus here. > > Also please look at other panels implementation: > drivers/video/omap2/displays/panel-tfp410.c > drivers/video/omap2/displays/panel-picodlp.c Yeah, it's the same problem with other i2c drivers, they should be written to be working as much as possible with the emulated smbus. I don't actually know the internals of the omap2 driver controller, but not being able to use smbus, definitely sucks! > Will be fixed in next patchset What about sending a patch V2? :) Andi