From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: linux-fbdev@vger.kernel.org, backports@vger.kernel.org,
FlorianSchandinat@gmx.de, daniel.vetter@ffwll.ch,
rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, rodrigo.vivi@gmail.com,
cocci@systeme.lip6.fr
Subject: Re: [PATCH] compat/compat-drivers/linux-next: fb skip_vt_switch
Date: Thu, 28 Mar 2013 15:39:43 +0000 [thread overview]
Message-ID: <20130328083943.01e61b4b@jbarnes-desktop> (raw)
In-Reply-To: <1364472270-9297-1-git-send-email-mcgrof@do-not-panic.com>
On Thu, 28 Mar 2013 05:04:26 -0700
"Luis R. Rodriguez" <mcgrof@do-not-panic.com> wrote:
> The new commit by Jesse that extended the fb_info with a skip_vt_switch
> element is the simplest example of a data structure expansion. We'd backport
> this by adding a static inline to compat so that new kernels muck with the
> new element and for older kernels this would be a no-op. This reduces the
> size of the backport and unclutters the required patch with #idefs, and
> insteads leaves only a replacement of the usage of the new elements with
> a static inline, this however would still be required on our end:
>
> - info->skip_vt_switch = true;
> + fb_enable_skip_vt_switch(info);
>
> So we'd then have to just add this static inline change for each new driver...
> There may be a way to get SmPL to do this for us...
Yeah I'm not attached to the direct structure reference; a couple of
inlines are just as easy to read. So no argument from me.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-03-28 15:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 12:04 [PATCH] compat/compat-drivers/linux-next: fb skip_vt_switch Luis R. Rodriguez
2013-03-28 12:04 ` [PATCH 1/4] compat-drivers: backport fb_info->skip_vt_switch using ifdefs Luis R. Rodriguez
2013-03-28 12:04 ` [PATCH 2/4] compat: backport fb_info->skip_vt_switch using a static inline Luis R. Rodriguez
2013-03-28 12:04 ` [PATCH 3/4] compat-drivers: simplify backport fb_info->skip_vt_switch CE Luis R. Rodriguez
2013-03-28 12:04 ` [PATCH 4/4] fb: add helpers to enable and test for the skip_vt_switch Luis R. Rodriguez
2013-03-28 15:39 ` Jesse Barnes [this message]
2013-03-28 16:19 ` [PATCH] compat/compat-drivers/linux-next: fb skip_vt_switch Julia Lawall
2013-03-28 18:05 ` Luis R. Rodriguez
2013-03-28 18:10 ` Julia Lawall
2013-03-28 18:25 ` Luis R. Rodriguez
2013-03-28 22:29 ` Julia Lawall
2013-03-28 23:25 ` Luis R. Rodriguez
2013-03-29 6:21 ` Julia Lawall
2013-03-29 7:29 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130328083943.01e61b4b@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=FlorianSchandinat@gmx.de \
--cc=backports@vger.kernel.org \
--cc=cocci@systeme.lip6.fr \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).