From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Fri, 31 May 2013 15:19:26 +0000 Subject: Re: [PATCH 2/2] atmel_lcdfb: blank the backlight on remove Message-Id: <20130531151926.GR19468@game.jcrosoft.org> List-Id: References: <1370010519-18691-1-git-send-email-richard.genoud@gmail.com> <1370010519-18691-2-git-send-email-richard.genoud@gmail.com> In-Reply-To: <1370010519-18691-2-git-send-email-richard.genoud@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Richard Genoud Cc: Nicolas Ferre , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On 16:28 Fri 31 May , Richard Genoud wrote: > When removing atmel_lcdfb module, the backlight is unregistered but not > blanked. (only for CONFIG_BACKLIGHT_ATMEL_LCDC case). > This can result in the screen going full white depending on how the PWM > is wired. > > Signed-off-by: Richard Genoud > --- > drivers/video/atmel_lcdfb.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c > index 6e6491f..e00318f 100644 > --- a/drivers/video/atmel_lcdfb.c > +++ b/drivers/video/atmel_lcdfb.c > @@ -223,8 +223,13 @@ static void init_backlight(struct atmel_lcdfb_info *sinfo) > > static void exit_backlight(struct atmel_lcdfb_info *sinfo) > { > - if (sinfo->backlight) > + if (sinfo->backlight) { if (!sinfo->backlight) return; other look ok if you want ot hte next RC you have 3h to send a v2 before I work off for few days Best Regards, J.