* re: uvesafb: Clean up MTRR code
@ 2013-06-06 7:49 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2013-06-06 7:49 UTC (permalink / raw)
To: linux-fbdev
Hello Andy Lutomirski,
This is a semi-automatic email about new static checker warnings.
The patch 63e28a7a5ffc: "uvesafb: Clean up MTRR code" from May 13,
2013, leads to the following Smatch complaint:
drivers/video/uvesafb.c:1819 uvesafb_remove()
warn: variable dereferenced before check 'par' (see line 1814)
drivers/video/uvesafb.c
1813 iounmap(info->screen_base);
1814 arch_phys_wc_del(par->mtrr_handle);
^^^^^^^^^^^^^^^^
New dereference.
1815 release_mem_region(info->fix.smem_start, info->fix.smem_len);
1816 fb_destroy_modedb(info->monspecs.modedb);
1817 fb_dealloc_cmap(&info->cmap);
1818
1819 if (par) {
^^^
Old check.
1820 if (par->vbe_modes)
1821 kfree(par->vbe_modes);
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-06-06 7:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-06 7:49 uvesafb: Clean up MTRR code Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).