From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Thu, 06 Jun 2013 16:23:36 +0000 Subject: Re: [PATCH v4 0/7] xilinxfb changes Message-Id: <20130606162336.GW19468@game.jcrosoft.org> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Simek Cc: Timur Tabi , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tomi Valkeinen , Grant Likely On 12:13 Mon 03 Jun , Michal Simek wrote: > Hi, > Arnd can you take look on it again please I'll take a look on it next week Best Regards, J. > I have done more changes in the driver to support probing > on little and big endian system where detection is done > directly on the hardware. > I have also done some cleanups to get it to the better shape. > > Thanks for your review, > Michal > > Changes in v4: > - Acked by Arnd > - Remove "video: xilinxfb: Fix sparse warnings" > patch because it is trying to fix incorrect API > usage and sparse should warn about it. > > Changes in v3: > - fix commit message > - Remove out_be IO name from function name > - Change patch subject from "Do not use out_be32 IO function" > to "Do not name out_be32 in function name" > - New patch in this patchset based on discussions > - New patch in this patchset based on discussions > - New patch in this patchset > - New patch in this patchset based on discussions > > Changes in v2: > - use of_property_read_u32 helper function > > Michal Simek (7): > video: xilinxfb: Fix OF probing on little-endian systems > video: xilinxfb: Do not name out_be32 in function name > video: xilinxfb: Rename PLB_ACCESS_FLAG to BUS_ACCESS_FLAG > video: xilinxfb: Use drvdata->regs_phys instead of physaddr > video: xilinxfb: Group bus initialization > video: xilinxfb: Add support for little endian accesses > video: xilinxfb: Use driver for Xilinx ARM Zynq > > drivers/video/Kconfig | 2 +- > drivers/video/xilinxfb.c | 135 +++++++++++++++++++++++------------------------ > 2 files changed, 68 insertions(+), 69 deletions(-) > > -- > 1.8.2.3 >