From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [V2 3/7] video: mmp: fix graphics/video layer enable/mask swap issue
Date: Wed, 12 Jun 2013 12:08:00 +0000 [thread overview]
Message-ID: <20130612120800.GC305@game.jcrosoft.org> (raw)
In-Reply-To: <1370879552-11290-1-git-send-email-jtzhou@marvell.com>
On 23:52 Mon 10 Jun , Jett.Zhou wrote:
> From: Jing Xiang <jxiang@marvell.com>
>
> There is bug when switch dma of graphic layer and video layer, it
> configured opposite bit, fix it.
>
> Signed-off-by: Jing Xiang <jxiang@marvell.com>
> Signed-off-by: Jett.Zhou <jtzhou@marvell.com>
do you need those 2 fixes for 3.10 or it can wait for 3.11?
Best Regards,
J.
> ---
> drivers/video/mmp/hw/mmp_ctrl.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/mmp/hw/mmp_ctrl.c b/drivers/video/mmp/hw/mmp_ctrl.c
> index 3a8c2a3..8836053 100644
> --- a/drivers/video/mmp/hw/mmp_ctrl.c
> +++ b/drivers/video/mmp/hw/mmp_ctrl.c
> @@ -160,9 +160,9 @@ static void overlay_set_win(struct mmp_overlay *overlay, struct mmp_win *win)
>
> static void dmafetch_onoff(struct mmp_overlay *overlay, int on)
> {
> - u32 mask = overlay_is_vid(overlay) ? CFG_GRA_ENA_MASK :
> - CFG_DMA_ENA_MASK;
> - u32 enable = overlay_is_vid(overlay) ? CFG_GRA_ENA(1) : CFG_DMA_ENA(1);
> + u32 mask = overlay_is_vid(overlay) ? CFG_DMA_ENA_MASK :
> + CFG_GRA_ENA_MASK;
> + u32 enable = overlay_is_vid(overlay) ? CFG_DMA_ENA(1) : CFG_GRA_ENA(1);
> u32 tmp;
> struct mmp_path *path = overlay->path;
>
> --
> 1.7.0.4
>
next prev parent reply other threads:[~2013-06-12 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1370879521-10962-1-git-send-email-jtzhou@marvell.com>
2013-06-11 17:05 ` [V2 0/7] Enhanced mmp fb driver and bugfix Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1370879552-11290-1-git-send-email-jtzhou@marvell.com>
2013-06-12 12:08 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-06-21 17:12 ` [V2 3/7] video: mmp: fix graphics/video layer enable/mask swap issue Daniel Drake
2013-06-24 10:17 ` jett zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130612120800.GC305@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).