From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 01/15] video: bfin: remove unnecessary platform_set_drvdata()
Date: Wed, 03 Jul 2013 11:10:56 +0000 [thread overview]
Message-ID: <20130703111056.GN305@game.jcrosoft.org> (raw)
On 10:45 Tue 25 Jun , Jingoo Han wrote:
> On Saturday, May 11, 2013 9:45 PM, Jingoo Han wrote:
> >
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> > (device-core: Ensure drvdata = NULL when no driver is bound).
> > Thus, it is not needed to manually clear the device driver data to NULL.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> Hi,
>
> I will squash everything down into one patch with the ACKs,
> and send it again.
fine by me
Best Regards,
J.
>
> Best regards,
> Jingoo Han
>
>
> > ---
> > drivers/video/bf54x-lq043fb.c | 1 -
> > drivers/video/bfin-lq035q1-fb.c | 2 --
> > drivers/video/bfin-t350mcqb-fb.c | 2 --
> > 3 files changed, 0 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c
> > index 2726a5b..87f288b 100644
> > --- a/drivers/video/bf54x-lq043fb.c
> > +++ b/drivers/video/bf54x-lq043fb.c
> > @@ -681,7 +681,6 @@ out3:
> > out2:
> > free_dma(CH_EPPI0);
> > out1:
> > - platform_set_drvdata(pdev, NULL);
> >
> > return ret;
> > }
> > diff --git a/drivers/video/bfin-lq035q1-fb.c b/drivers/video/bfin-lq035q1-fb.c
> > index 29d8c04..be65bae 100644
> > --- a/drivers/video/bfin-lq035q1-fb.c
> > +++ b/drivers/video/bfin-lq035q1-fb.c
> > @@ -759,7 +759,6 @@ static int bfin_lq035q1_probe(struct platform_device *pdev)
> > out2:
> > free_dma(CH_PPI);
> > out1:
> > - platform_set_drvdata(pdev, NULL);
> >
> > return ret;
> > }
> > @@ -788,7 +787,6 @@ static int bfin_lq035q1_remove(struct platform_device *pdev)
> > bfin_lq035q1_free_ports(info->disp_info->ppi_mode =
> > USE_RGB565_16_BIT_PPI);
> >
> > - platform_set_drvdata(pdev, NULL);
> > framebuffer_release(fbinfo);
> >
> > dev_info(&pdev->dev, "unregistered LCD driver\n");
> > diff --git a/drivers/video/bfin-t350mcqb-fb.c b/drivers/video/bfin-t350mcqb-fb.c
> > index d46da01..48c0c4e 100644
> > --- a/drivers/video/bfin-t350mcqb-fb.c
> > +++ b/drivers/video/bfin-t350mcqb-fb.c
> > @@ -578,7 +578,6 @@ out3:
> > out2:
> > free_dma(CH_PPI);
> > out1:
> > - platform_set_drvdata(pdev, NULL);
> >
> > return ret;
> > }
> > @@ -608,7 +607,6 @@ static int bfin_t350mcqb_remove(struct platform_device *pdev)
> >
> > bfin_t350mcqb_request_ports(0);
> >
> > - platform_set_drvdata(pdev, NULL);
> > framebuffer_release(fbinfo);
> >
> > printk(KERN_INFO DRIVER_NAME ": Unregister LCD driver.\n");
> > --
> > 1.7.2.5
>
>
next reply other threads:[~2013-07-03 11:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 11:10 Jean-Christophe PLAGNIOL-VILLARD [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-25 1:45 [PATCH 01/15] video: bfin: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-11 12:45 Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130703111056.GN305@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).