From: Mark Brown <broonie@kernel.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/15] drivers: phy: add generic PHY framework
Date: Tue, 23 Jul 2013 19:31:05 +0000 [thread overview]
Message-ID: <20130723193105.GP9858@sirena.org.uk> (raw)
In-Reply-To: <20130723180110.GA8688@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]
On Tue, Jul 23, 2013 at 11:01:10AM -0700, Greg KH wrote:
> On Tue, Jul 23, 2013 at 06:44:56PM +0100, Mark Brown wrote:
> > What are the problems you are seeing with doing things with lookups?
> You don't "know" the id of the device you are looking up, due to
> multiple devices being in the system (dynamic ids, look back earlier in
> this thread for details about that.)
I got copied in very late so don't have most of the thread I'm afraid,
I did try looking at web archives but didn't see a clear problem
statement. In any case this is why the APIs doing lookups do the
lookups in the context of the requesting device - devices ask for
whatever name they use locally.
> > Having to write platform data for everything gets old fast and the code
> > duplication is pretty tedious...
> Adding a single pointer is "tedious"? Where is the "name" that you are
> going to lookup going to come from? That code doesn't write itself...
It's adding platform data in the first place that gets tedious - and of
course there's also DT and ACPI to worry about, it's not just a case of
platform data and then you're done. Pushing the lookup into library
code means that drivers don't have to worry about any of this stuff.
For most of the APIs doing this there is a clear and unambiguous name in
the hardware that can be used (and for hardware process reasons is
unlikely to get changed). The major exception to this is the clock API
since it is relatively rare to have clear, segregated IP level
information for IPs baked into larger chips. The other APIs tend to be
establishing chip to chip links.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-23 19:31 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 6:58 [PATCH 00/15] PHY framework Kishon Vijay Abraham I
2013-07-18 6:58 ` [PATCH 01/15] drivers: phy: add generic " Kishon Vijay Abraham I
2013-07-18 7:20 ` Greg KH
2013-07-18 9:11 ` Kishon Vijay Abraham I
2013-07-18 15:49 ` Greg KH
2013-07-19 5:49 ` Kishon Vijay Abraham I
2013-07-19 5:43 ` Greg KH
2013-07-19 5:56 ` Kishon Vijay Abraham I
2013-07-19 6:29 ` Greg KH
2013-07-19 6:48 ` Kishon Vijay Abraham I
2013-07-19 15:54 ` Stephen Warren
2013-07-20 3:27 ` Kishon Vijay Abraham I
2013-07-19 23:50 ` Greg KH
2013-07-20 3:31 ` Kishon Vijay Abraham I
2013-07-20 22:00 ` Greg KH
2013-07-21 2:32 ` Alan Stern
2013-07-21 2:59 ` Greg KH
2013-07-21 10:22 ` Sascha Hauer
2013-07-21 15:48 ` Greg KH
2013-07-21 17:14 ` Sylwester Nawrocki
2013-07-21 19:22 ` Alan Stern
2013-07-22 7:37 ` Kishon Vijay Abraham I
2013-07-22 14:44 ` Alan Stern
2013-07-23 5:59 ` Kishon Vijay Abraham I
2013-07-23 7:29 ` Tomasz Figa
2013-07-23 7:55 ` Tomasz Figa
2013-07-23 14:37 ` Alan Stern
2013-07-23 14:50 ` Tomasz Figa
2013-07-23 15:30 ` Kishon Vijay Abraham I
2013-07-23 16:18 ` Greg KH
2013-07-23 16:40 ` Kishon Vijay Abraham I
2013-07-23 16:35 ` Greg KH
2013-07-23 16:50 ` Tomasz Figa
2013-07-23 17:37 ` Greg KH
2013-07-23 17:44 ` Mark Brown
2013-07-23 18:01 ` Greg KH
2013-07-23 19:31 ` Mark Brown [this message]
2013-07-23 19:44 ` Greg KH
2013-07-23 20:07 ` Tomasz Figa
2013-07-23 20:50 ` Greg KH
2013-07-23 21:05 ` Tomasz Figa
2013-07-23 21:23 ` Greg KH
2013-07-23 23:48 ` Mark Brown
2013-07-23 17:48 ` Tomasz Figa
2013-07-23 18:04 ` Greg KH
2013-07-23 20:46 ` Tomasz Figa
2013-07-23 19:36 ` Alan Stern
2013-07-23 20:20 ` Tomasz Figa
2013-07-23 20:53 ` Alan Stern
2013-07-23 21:02 ` Tomasz Figa
2013-07-23 21:14 ` Alan Stern
2013-07-23 21:31 ` Tomasz Figa
2013-07-24 18:32 ` Arnd Bergmann
[not found] ` <51F0B373.5050907@ti.com>
2013-07-25 7:54 ` Arnd Bergmann
2013-07-25 9:29 ` Sylwester Nawrocki
2013-07-25 9:29 ` Mark Brown
2013-07-25 10:16 ` Laurent Pinchart
2013-07-25 11:00 ` Arnd Bergmann
2013-07-25 11:10 ` Laurent Pinchart
2013-07-25 12:09 ` Mark Brown
2013-07-23 17:34 ` Mark Brown
2013-07-22 15:04 ` Greg KH
2013-07-23 5:46 ` Kishon Vijay Abraham I
2013-07-21 10:31 ` Tomasz Figa
2013-07-21 11:19 ` Kishon Vijay Abraham I
2013-07-21 11:12 ` Tomasz Figa
2013-07-21 15:46 ` Greg KH
2013-07-30 7:11 ` Felipe Balbi
2013-07-31 5:56 ` Kishon Vijay Abraham I
2013-07-31 6:15 ` Felipe Balbi
2013-08-13 10:56 ` Kishon Vijay Abraham I
2013-08-13 11:37 ` Tomasz Figa
2013-08-13 12:17 ` Kishon Vijay Abraham I
2013-08-13 22:19 ` Sylwester Nawrocki
2013-08-13 23:04 ` Tomasz Figa
2013-08-14 15:17 ` Kishon Vijay Abraham I
2013-08-19 5:40 ` Kishon Vijay Abraham I
2013-08-20 12:26 ` Felipe Balbi
2013-07-18 6:58 ` [PATCH 02/15] usb: phy: omap-usb2: use the new " Kishon Vijay Abraham I
2013-07-18 7:21 ` Greg KH
2013-07-18 9:12 ` Kishon Vijay Abraham I
2013-07-18 6:58 ` [PATCH 03/15] usb: phy: twl4030: " Kishon Vijay Abraham I
2013-07-18 6:58 ` [PATCH 04/15] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
2013-07-18 7:02 ` Tony Lindgren
2013-07-18 6:58 ` [PATCH 05/15] ARM: dts: omap: update usb_otg_hs data Kishon Vijay Abraham I
2013-07-18 7:05 ` Tony Lindgren
2013-07-18 6:58 ` [PATCH 06/15] usb: musb: omap2430: use the new generic PHY framework Kishon Vijay Abraham I
2013-07-18 6:58 ` [PATCH 07/15] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2 Kishon Vijay Abraham I
2013-07-18 6:58 ` [PATCH 08/15] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops Kishon Vijay Abraham I
2013-07-18 6:58 ` [PATCH 09/15] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs Kishon Vijay Abraham I
2013-07-18 6:58 ` [PATCH 10/15] video: exynos_mipi_dsim: Use the generic PHY driver Kishon Vijay Abraham I
2013-07-18 6:58 ` [PATCH 11/15] exynos4-is: Use the generic MIPI CSIS " Kishon Vijay Abraham I
2013-07-18 6:58 ` [PATCH 12/15] ARM: Samsung: Remove the MIPI PHY setup code Kishon Vijay Abraham I
2013-07-18 6:58 ` [PATCH 13/15] phy: Add driver for Exynos DP PHY Kishon Vijay Abraham I
2013-07-18 6:58 ` [PATCH 14/15] video: exynos_dp: remove non-DT support for Exynos Display Port Kishon Vijay Abraham I
2013-07-18 6:58 ` [PATCH 15/15] video: exynos_dp: Use the generic PHY driver Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723193105.GP9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).