From: Darren Etheridge <detheridge@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 10/24] video: da8xx-fb: fb_set_par support
Date: Thu, 01 Aug 2013 13:54:12 +0000 [thread overview]
Message-ID: <20130801135412.GB27598@ti.com> (raw)
In-Reply-To: <1375208791-15781-11-git-send-email-detheridge@ti.com>
Tomi Valkeinen <tomi.valkeinen@ti.com> wrote on Wed [2013-Jul-31 14:38:52 +0300]:
> >
> > +static inline bool da8xx_fb_is_raster_enabled(void)
> > +{
> > + return !!(lcdc_read(LCD_RASTER_CTRL_REG) & LCD_RASTER_ENABLE);
> > +}
>
> See Documentation/CodingStyle about inline.
>
> I think, generally, it's better not to use inline at all in normal
> functions. Let the compiler decide. Even more so with funcs like
> da8xx_fb_is_raster_enabled(), which I guess is only used rarely.
>
> There are some inlines added in other patches in the series also.
>
I have added a new patch to the update series that removes the use of
inline from all offending places.
Darren
next prev parent reply other threads:[~2013-08-01 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 18:26 [PATCH v2 10/24] video: da8xx-fb: fb_set_par support Darren Etheridge
2013-07-31 11:38 ` Tomi Valkeinen
2013-07-31 18:56 ` Etheridge, Darren
2013-08-01 5:44 ` Tomi Valkeinen
2013-08-01 11:12 ` Etheridge, Darren
2013-08-01 13:54 ` Darren Etheridge [this message]
2013-08-01 20:30 ` Darren Etheridge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801135412.GB27598@ti.com \
--to=detheridge@ti.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).