From: Darren Etheridge <detheridge@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 10/24] video: da8xx-fb: fb_set_par support
Date: Thu, 01 Aug 2013 20:30:17 +0000 [thread overview]
Message-ID: <20130801203017.GC17271@ti.com> (raw)
In-Reply-To: <1375208791-15781-11-git-send-email-detheridge@ti.com>
Tomi Valkeinen <tomi.valkeinen@ti.com> wrote on Thu [2013-Aug-01 08:44:00 +0300]:
> On 31/07/13 21:56, Etheridge, Darren wrote:
> >>>
> >>> +static int da8xxfb_set_par(struct fb_info *info) {
> >>> + struct da8xx_fb_par *par = info->par;
> >>> + int ret;
> >>> + bool raster = da8xx_fb_is_raster_enabled();
> >>> +
> >>> + if (raster)
> >>> + lcd_disable_raster(true);
> >>> + else
> >>> + lcd_disable_raster(false);
> >>
> >> This looks odd. If raster is enabled, you disable it. And if raster is disabled,
> >> you disable it.
> >
> > I corrected this one in patch 0011 - I agree this code is very confusing.
>
> In patch 11 you add the enum. I wasn't referring to that. My point was
> that even if raster is already disabled,
> lcd_disable_raster(dont-wait-for-framedone) is called.
Agreed and removed, the lcd_disable_raster function does the same
check as da8xx_fb_is_raster_enabled() and the immediately exits if not
enabled so this path of the conditional appears completely redundant.
Darren
prev parent reply other threads:[~2013-08-01 20:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 18:26 [PATCH v2 10/24] video: da8xx-fb: fb_set_par support Darren Etheridge
2013-07-31 11:38 ` Tomi Valkeinen
2013-07-31 18:56 ` Etheridge, Darren
2013-08-01 5:44 ` Tomi Valkeinen
2013-08-01 11:12 ` Etheridge, Darren
2013-08-01 13:54 ` Darren Etheridge
2013-08-01 20:30 ` Darren Etheridge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801203017.GC17271@ti.com \
--to=detheridge@ti.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).