From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [patch] tgafb: potential NULL dereference in init
Date: Tue, 27 Aug 2013 01:16:02 +0000 [thread overview]
Message-ID: <20130827011602.GH6329@mwanda> (raw)
In-Reply-To: <20130826145610.GA12428@elgon.mountain>
On Mon, Aug 26, 2013 at 07:51:04PM +0200, Geert Uytterhoeven wrote:
> On Mon, Aug 26, 2013 at 4:56 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > --- a/drivers/video/tgafb.c
> > +++ b/drivers/video/tgafb.c
> > @@ -1475,7 +1475,7 @@ tgafb_init_fix(struct fb_info *info)
> > int tga_bus_pci = TGA_BUS_PCI(par->dev);
> > int tga_bus_tc = TGA_BUS_TC(par->dev);
> > u8 tga_type = par->tga_type;
> > - const char *tga_type_name = NULL;
> > + const char *tga_type_name;
>
> Now the real compiler (at least some versions of gcc) will complain
> about an uninitialized variable...
Oh crap! The compiler is totally correct here. I don't know what I was
thinking. I've just double checked now and my compiler does not catch
this (GCC 4.7.2).
Sorry about that.
regards,
dan carpenter
prev parent reply other threads:[~2013-08-27 1:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 14:56 [patch] tgafb: potential NULL dereference in init Dan Carpenter
2013-08-26 17:51 ` Geert Uytterhoeven
2013-08-27 1:16 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827011602.GH6329@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox