From: Jean Delvare <khali@linux-fr.org>
To: linux-fbdev@vger.kernel.org
Subject: [PATCH v2] video/matrox/matroxfb_maven: Use module_i2c_driver to register driver
Date: Fri, 13 Sep 2013 19:51:50 +0000 [thread overview]
Message-ID: <20130913215150.16089f46@endymion.delvare> (raw)
From: Peter Huewe <peterhuewe@gmx.de>
Removing some boilerplate by using module_i2c_driver instead of calling
register and unregister in the otherwise empty init/exit functions.
Also removed a useless comment as suggested by Jean Delvare.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
Looks like this patch got lost so I am resending it.
drivers/video/matrox/matroxfb_maven.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
--- linux-3.12-rc0.orig/drivers/video/matrox/matroxfb_maven.c 2013-09-13 21:48:12.585102831 +0200
+++ linux-3.12-rc0/drivers/video/matrox/matroxfb_maven.c 2013-09-13 21:48:28.843103072 +0200
@@ -1295,19 +1295,7 @@ static struct i2c_driver maven_driver={
.id_table = maven_id,
};
-static int __init matroxfb_maven_init(void)
-{
- return i2c_add_driver(&maven_driver);
-}
-
-static void __exit matroxfb_maven_exit(void)
-{
- i2c_del_driver(&maven_driver);
-}
-
+module_i2c_driver(maven_driver);
MODULE_AUTHOR("(c) 1999-2002 Petr Vandrovec <vandrove@vc.cvut.cz>");
MODULE_DESCRIPTION("Matrox G200/G400 Matrox MGA-TVO driver");
MODULE_LICENSE("GPL");
-module_init(matroxfb_maven_init);
-module_exit(matroxfb_maven_exit);
-/* we do not have __setup() yet */
--
Jean Delvare
next reply other threads:[~2013-09-13 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 19:51 Jean Delvare [this message]
2013-09-16 10:37 ` [PATCH v2] video/matrox/matroxfb_maven: Use module_i2c_driver to register driver Tomi Valkeinen
-- strict thread matches above, loose matches on Subject: below --
2013-05-20 19:42 [PATCH] " Jean Delvare
2013-05-20 19:56 ` [PATCH v2] " Peter Huewe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913215150.16089f46@endymion.delvare \
--to=khali@linux-fr.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).