From: Anatolij Gustschin <agust@denx.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 04/15] video: mb862xx: Remove redundant dev_set_drvdata
Date: Sat, 21 Sep 2013 08:37:11 +0000 [thread overview]
Message-ID: <20130921103711.24e8f147@crub> (raw)
In-Reply-To: <1379658744-17113-5-git-send-email-sachin.kamat@linaro.org>
On Fri, 20 Sep 2013 12:02:13 +0530
Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Anatolij Gustschin <agust@denx.de>
Acked-by: Anatolij Gustschin <agust@denx.de>
> ---
> drivers/video/mb862xx/mb862xxfbdrv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/mb862xx/mb862xxfbdrv.c b/drivers/video/mb862xx/mb862xxfbdrv.c
> index 98d2f8c..0cd4c33 100644
> --- a/drivers/video/mb862xx/mb862xxfbdrv.c
> +++ b/drivers/video/mb862xx/mb862xxfbdrv.c
> @@ -781,7 +781,6 @@ rel_reg:
> irqdisp:
> irq_dispose_mapping(par->irq);
> fbrel:
> - dev_set_drvdata(dev, NULL);
> framebuffer_release(info);
> return ret;
> }
> @@ -814,7 +813,6 @@ static int of_platform_mb862xx_remove(struct platform_device *ofdev)
> iounmap(par->mmio_base);
> iounmap(par->fb_base);
>
> - dev_set_drvdata(&ofdev->dev, NULL);
> release_mem_region(par->res->start, res_size);
> framebuffer_release(fbi);
> return 0;
prev parent reply other threads:[~2013-09-21 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 6:44 [PATCH 04/15] video: mb862xx: Remove redundant dev_set_drvdata Sachin Kamat
2013-09-21 8:37 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130921103711.24e8f147@crub \
--to=agust@denx.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).