* Re: [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init()
2013-09-25 8:54 [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init() Dan Carpenter
@ 2013-09-25 9:30 ` Jingoo Han
2013-09-25 9:35 ` Dan Carpenter
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-09-25 9:30 UTC (permalink / raw)
To: linux-fbdev
On Wednesday, September 25, 2013 5:55 PM, Dan Carpenter wrote:
>
> "rval" needs to be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
CC'ed Andrew Morton, Daniel Jeong,
Acked-by: Jingoo Han <jg1.han@samsung.com>
>
> diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> index c63f918..65392f9 100644
> --- a/drivers/video/backlight/lm3630a_bl.c
> +++ b/drivers/video/backlight/lm3630a_bl.c
> @@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
> /* interrupt handling */
> static void lm3630a_delayed_func(struct work_struct *work)
> {
> - unsigned int rval;
> + int rval;
> struct lm3630a_chip *pchip;
>
> pchip = container_of(work, struct lm3630a_chip, work.work);
^ permalink raw reply [flat|nested] 5+ messages in thread* [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init()
2013-09-25 8:54 [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init() Dan Carpenter
2013-09-25 9:30 ` Jingoo Han
@ 2013-09-25 9:35 ` Dan Carpenter
2013-09-26 9:43 ` Tomi Valkeinen
2013-09-26 9:53 ` Dan Carpenter
3 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2013-09-25 9:35 UTC (permalink / raw)
To: linux-fbdev
"rval" needs to be signed for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index c63f918..65392f9 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
/* interrupt handling */
static void lm3630a_delayed_func(struct work_struct *work)
{
- unsigned int rval;
+ int rval;
struct lm3630a_chip *pchip;
pchip = container_of(work, struct lm3630a_chip, work.work);
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init()
2013-09-25 8:54 [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init() Dan Carpenter
2013-09-25 9:30 ` Jingoo Han
2013-09-25 9:35 ` Dan Carpenter
@ 2013-09-26 9:43 ` Tomi Valkeinen
2013-09-26 9:53 ` Dan Carpenter
3 siblings, 0 replies; 5+ messages in thread
From: Tomi Valkeinen @ 2013-09-26 9:43 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
On 25/09/13 11:54, Dan Carpenter wrote:
> "rval" needs to be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> index c63f918..65392f9 100644
> --- a/drivers/video/backlight/lm3630a_bl.c
> +++ b/drivers/video/backlight/lm3630a_bl.c
> @@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
> /* interrupt handling */
> static void lm3630a_delayed_func(struct work_struct *work)
> {
> - unsigned int rval;
> + int rval;
> struct lm3630a_chip *pchip;
>
> pchip = container_of(work, struct lm3630a_chip, work.work);
>
There's no drivers/video/backlight/lm3630a_bl.c in v3.12. Which kernel
is this for?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init()
2013-09-25 8:54 [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init() Dan Carpenter
` (2 preceding siblings ...)
2013-09-26 9:43 ` Tomi Valkeinen
@ 2013-09-26 9:53 ` Dan Carpenter
3 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2013-09-26 9:53 UTC (permalink / raw)
To: linux-fbdev
On Thu, Sep 26, 2013 at 12:43:43PM +0300, Tomi Valkeinen wrote:
> On 25/09/13 11:54, Dan Carpenter wrote:
> > "rval" needs to be signed for the error handling to work.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> > index c63f918..65392f9 100644
> > --- a/drivers/video/backlight/lm3630a_bl.c
> > +++ b/drivers/video/backlight/lm3630a_bl.c
> > @@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
> > /* interrupt handling */
> > static void lm3630a_delayed_func(struct work_struct *work)
> > {
> > - unsigned int rval;
> > + int rval;
> > struct lm3630a_chip *pchip;
> >
> > pchip = container_of(work, struct lm3630a_chip, work.work);
> >
>
> There's no drivers/video/backlight/lm3630a_bl.c in v3.12. Which kernel
> is this for?
>
The story is that this driver wasn't submitted to you or to linux-fbdev
but only to lkml.
Andrew Morton (the only person who reads LKML) picked it up in his tree.
Probably at some point he will prod you into taking it through your
tree. Anyway, I resent the patches so they're in -mm now.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread