From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Fri, 25 Oct 2013 11:09:28 +0000 Subject: Re: [PATCH 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove Message-Id: <20131025110928.GR18477@ns203013.ovh.net> List-Id: References: <1382522143-32072-1-git-send-email-jhovold@gmail.com> <1382522143-32072-3-git-send-email-jhovold@gmail.com> In-Reply-To: <1382522143-32072-3-git-send-email-jhovold@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Johan Hovold Cc: Richard Purdie , Jingoo Han , Nicolas Ferre , Tomi Valkeinen , Andrew Morton , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org On 11:55 Wed 23 Oct , Johan Hovold wrote: > Make sure to honour gpio polarity also at remove so that the backlight > is actually disabled on boards with active-low enable pin. > > Cc: stable@vger.kernel.org > Acked-by: Jingoo Han > Signed-off-by: Johan Hovold > --- > drivers/video/backlight/atmel-pwm-bl.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c > index 8aac273..3cb0094 100644 > --- a/drivers/video/backlight/atmel-pwm-bl.c > +++ b/drivers/video/backlight/atmel-pwm-bl.c > @@ -205,8 +205,10 @@ static int atmel_pwm_bl_remove(struct platform_device *pdev) > { > struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev); > > - if (pwmbl->gpio_on != -1) > - gpio_set_value(pwmbl->gpio_on, 0); > + if (pwmbl->gpio_on != -1) { here we need to use gpio_is_valid > + gpio_set_value(pwmbl->gpio_on, > + 0 ^ pwmbl->pdata->on_active_low); > + } > pwm_channel_disable(&pwmbl->pwmc); > pwm_channel_free(&pwmbl->pwmc); > > -- > 1.8.4 >