From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Fri, 25 Oct 2013 11:15:43 +0000 Subject: Re: [PATCH 9/9] backlight: atmel-pwm-bl: use gpio_request_one Message-Id: <20131025111543.GV18477@ns203013.ovh.net> List-Id: References: <1382522143-32072-1-git-send-email-jhovold@gmail.com> <1382522143-32072-10-git-send-email-jhovold@gmail.com> In-Reply-To: <1382522143-32072-10-git-send-email-jhovold@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Johan Hovold Cc: Richard Purdie , Jingoo Han , Nicolas Ferre , Tomi Valkeinen , Andrew Morton , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On 11:55 Wed 23 Oct , Johan Hovold wrote: > Use devm_gpio_request_one rather than requesting and setting direction > in two calls. this is the same I do not see any advantage and as I said for ather backligth It's wrong to enable or disable it at probe as the bootloader might have already enable it for splash screen Best Regards, J. > > Acked-by: Jingoo Han :w > Signed-off-by: Johan Hovold > --- > drivers/video/backlight/atmel-pwm-bl.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c > index 1277e0c..5ea2517 100644 > --- a/drivers/video/backlight/atmel-pwm-bl.c > +++ b/drivers/video/backlight/atmel-pwm-bl.c > @@ -124,6 +124,7 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev) > const struct atmel_pwm_bl_platform_data *pdata; > struct backlight_device *bldev; > struct atmel_pwm_bl *pwmbl; > + int flags; > int retval; > > pdata = dev_get_platdata(&pdev->dev); > @@ -149,14 +150,14 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev) > return retval; > > if (gpio_is_valid(pwmbl->gpio_on)) { > - retval = devm_gpio_request(&pdev->dev, pwmbl->gpio_on, > - "gpio_atmel_pwm_bl"); > - if (retval) > - goto err_free_pwm; > - > /* Turn display off by default. */ > - retval = gpio_direction_output(pwmbl->gpio_on, > - 0 ^ pdata->on_active_low); > + if (pdata->on_active_low) > + flags = GPIOF_OUT_INIT_HIGH; > + else > + flags = GPIOF_OUT_INIT_LOW; > + > + retval = devm_gpio_request_one(&pdev->dev, pwmbl->gpio_on, > + flags, "gpio_atmel_pwm_bl"); > if (retval) > goto err_free_pwm; > } > -- > 1.8.4 >