From: Kyungmin Park <kmpark@infradead.org>
To: Richard Purdie <rpurdie@rpsys.net>, Jingoo Han <jg1.han@samsung.com>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kay@vrfy.org
Subject: [PATCH] video: backlight: Remove backlight sysfs uevent
Date: Mon, 11 Nov 2013 23:57:00 +0000 [thread overview]
Message-ID: <20131111235700.GA29987@july> (raw)
From: Kyungmin Park <kyungmin.park@samsung.com>
The most mobile phones have Ambient Light Sensors and it changes brightness according lux.
It means it changes backlight brightness frequently by just writing sysfs node, so it generates uevent.
Usually there's no user to use this backlight changes. But it forks udev worker threads and it takes about 5ms. The main problem is that it hurts other process activities. so remove it.
Kay said
"Uevents are for the major, low-frequent, global device state-changes,
not for carrying-out any sort of measurement data. Subsystems which
need that should use other facilities like poll()-able sysfs file or
any other subscription-based, client-tracking interface which does not
cause overhead if it isn't used. Uevents are not the right thing to
use here, and upstream udev should not paper-over broken kernel
subsystems."
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index 94a403a..441272d 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -88,9 +88,6 @@ static void backlight_generate_event(struct backlight_device *bd,
char *envp[2];
switch (reason) {
- case BACKLIGHT_UPDATE_SYSFS:
- envp[0] = "SOURCE=sysfs";
- break;
case BACKLIGHT_UPDATE_HOTKEY:
envp[0] = "SOURCE=hotkey";
break;
@@ -172,8 +169,6 @@ static ssize_t brightness_store(struct device *dev,
}
mutex_unlock(&bd->ops_lock);
- backlight_generate_event(bd, BACKLIGHT_UPDATE_SYSFS);
-
return rc;
}
static DEVICE_ATTR_RW(brightness);
diff --git a/include/linux/backlight.h b/include/linux/backlight.h
index 53b7794..d2a27dd 100644
--- a/include/linux/backlight.h
+++ b/include/linux/backlight.h
@@ -29,7 +29,6 @@
enum backlight_update_reason {
BACKLIGHT_UPDATE_HOTKEY,
- BACKLIGHT_UPDATE_SYSFS,
};
enum backlight_type {
next reply other threads:[~2013-11-11 23:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 23:57 Kyungmin Park [this message]
2013-11-12 0:18 ` [PATCH] video: backlight: Remove backlight sysfs uevent Jingoo Han
2013-11-12 0:56 ` Henrique de Moraes Holschuh
2013-11-12 1:07 ` Kyungmin Park
2013-11-12 1:19 ` Kay Sievers
2013-11-12 2:08 ` Kyungmin Park
2013-11-12 2:22 ` Kay Sievers
2013-11-20 23:40 ` Matthew Garrett
2013-11-21 11:43 ` Henrique de Moraes Holschuh
2013-11-21 14:33 ` Matthew Garrett
2013-11-22 11:36 ` Henrique de Moraes Holschuh
2013-11-22 17:15 ` Matthew Garrett
2013-11-24 0:40 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2013-11-24 1:02 ` Matthew Garrett
2013-11-24 3:53 ` Henrique de Moraes Holschuh
2013-12-16 7:53 ` Andrew Morton
2013-11-12 0:44 ` Kyungmin Park
2013-11-12 0:54 ` Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111235700.GA29987@july \
--to=kmpark@infradead.org \
--cc=jg1.han@samsung.com \
--cc=kay@vrfy.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).