From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
'Tomi Valkeinen' <tomi.valkeinen@ti.com>,
'Jean-Christophe PLAGNIOL-VILLARD' <plagnioj@jcrosoft.com>
Subject: Re: [PATCH v2] video: add OpenCores VGA/LCD framebuffer driver
Date: Wed, 20 Nov 2013 19:13:30 +0000 [thread overview]
Message-ID: <20131120191328.GA30494@chokladfabriken.org> (raw)
In-Reply-To: <000701cee5b8$9b61e3b0$d225ab10$%han@samsung.com>
On Wed, Nov 20, 2013 at 03:20:28PM +0900, Jingoo Han wrote:
> On Wednesday, November 20, 2013 1:14 PM, Stefan Kristiansson wrote:
>
> > +static int ocfb_probe(struct platform_device *pdev)
> > +{
> > + int ret = 0;
> > + struct ocfb_dev *fbdev;
> > + struct ocfb_par *par = &ocfb_par_priv;
> > + struct resource *res;
> > + struct resource *mmio;
> > + int fbsize;
> > +
> > + fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL);
>
> Please use devm_kzalloc() instead of kzalloc().
> In this case, kfree() can be removed from ocfb_probe()
> and ocfb_remove(). Thus, it will make the code smaller.
>
Nice, thanks for the hint!
Consider it done.
> [.....]
>
> > +
> > +#ifdef MODULE
>
> I don't think that '#ifdef MODULE' is necessary.
> Is there any reason?
>
You're right, that's not necessary, I'll remove that.
Thanks alot for taking the time to review it!
Stefan
prev parent reply other threads:[~2013-11-20 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 4:13 [PATCH v2] video: add OpenCores VGA/LCD framebuffer driver Stefan Kristiansson
2013-11-20 6:20 ` Jingoo Han
2013-11-20 19:13 ` Stefan Kristiansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131120191328.GA30494@chokladfabriken.org \
--to=stefan.kristiansson@saunalahti.fi \
--cc=jg1.han@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox