From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Jingoo Han <jg1.han@samsung.com>,
'Kyungmin Park' <kmpark@infradead.org>,
'Henrique de Moraes Holschuh' <ibm-acpi@hmh.eng.br>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kay@vrfy.org, 'Richard Purdie' <rpurdie@rpsys.net>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] video: backlight: Remove backlight sysfs uevent
Date: Thu, 21 Nov 2013 14:33:26 +0000 [thread overview]
Message-ID: <20131121143326.GA19773@srcf.ucam.org> (raw)
In-Reply-To: <20131121114332.GA23710@khazad-dum.debian.net>
On Thu, Nov 21, 2013 at 09:43:32AM -0200, Henrique de Moraes Holschuh wrote:
> With this patchset applied, as far as I can tell anything that used to be
> uevent-driven by the backlight class will break: when a process changes the
> backlight using sysfs, other processes will not be notified of the change
> anymore. This patchset seems to break backlight uevent support in such a
> way that basically renders the entire thing useless and you might as well
> just remove uevent support entirely.
The uevent support was initially added to handle systems where pressing
a hotkey generates an event (good) but the firmware automatically
changes the brightness (bad). I have absolutely no idea why I added
BACKLIGHT_UPDATE_SYSFS - BACKLIGHT_UPDATE_HOTKEY solves the problem I
was trying to solve. I'm not aware of any userspace that relies on
BACKLIGHT_UPDATE_SYSFS.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-11-21 14:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 23:57 [PATCH] video: backlight: Remove backlight sysfs uevent Kyungmin Park
2013-11-12 0:18 ` Jingoo Han
2013-11-12 0:56 ` Henrique de Moraes Holschuh
2013-11-12 1:07 ` Kyungmin Park
2013-11-12 1:19 ` Kay Sievers
2013-11-12 2:08 ` Kyungmin Park
2013-11-12 2:22 ` Kay Sievers
2013-11-20 23:40 ` Matthew Garrett
2013-11-21 11:43 ` Henrique de Moraes Holschuh
2013-11-21 14:33 ` Matthew Garrett [this message]
2013-11-22 11:36 ` Henrique de Moraes Holschuh
2013-11-22 17:15 ` Matthew Garrett
2013-11-24 0:40 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2013-11-24 1:02 ` Matthew Garrett
2013-11-24 3:53 ` Henrique de Moraes Holschuh
2013-12-16 7:53 ` Andrew Morton
2013-11-12 0:44 ` Kyungmin Park
2013-11-12 0:54 ` Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121143326.GA19773@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=jg1.han@samsung.com \
--cc=kay@vrfy.org \
--cc=kmpark@infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).