linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	tomi.valkeinen@ti.com
Subject: Re: [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver
Date: Tue, 26 Nov 2013 06:55:52 +0000	[thread overview]
Message-ID: <20131126065551.GA2838@chokladfabriken.org> (raw)
In-Reply-To: <20131124141211.GH18477@ns203013.ovh.net>

On Sun, Nov 24, 2013 at 03:12:11PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 06:34 Fri 22 Nov     , Stefan Kristiansson wrote:
> > This adds support for the VGA/LCD core available from OpenCores:
> > http://opencores.org/project,vga_lcd
> > 
> > The driver have been tested together with both OpenRISC and
> > ARM (socfpga) processors.
> > 
> > Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> 
> Tomi hold on this one I need check fee stuff on it
> > ---
> > Changes in v2:
> > - Add Microblaze as an example user and fix a typo in Xilinx Zynq
> > 
> > Changes in v3:
> > - Use devm_kzalloc instead of kzalloc
> > - Remove superflous MODULE #ifdef
> > ---
> >  drivers/video/Kconfig  |  17 ++
> >  drivers/video/Makefile |   1 +
> >  drivers/video/ocfb.c   | 471 +++++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 489 insertions(+)
> >  create mode 100644 drivers/video/ocfb.c
> > 
> > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> > index 84b685f..3b3f31e 100644
> > --- a/drivers/video/Kconfig
> > +++ b/drivers/video/Kconfig
> > @@ -979,6 +979,23 @@ config FB_PVR2
> >  	  (<file:drivers/video/pvr2fb.c>). Please see the file
> >  	  <file:Documentation/fb/pvr2fb.txt>.
> >  
> > +config FB_OPENCORES
> > +	tristate "OpenCores VGA/LCD core 2.0 framebuffer support"
> > +	depends on FB
> > +	select FB_CFB_FILLRECT
> > +	select FB_CFB_COPYAREA
> > +	select FB_CFB_IMAGEBLIT
> > +	default n
> non need
> 

Ok, let's get rid of that then.

I'll hold on to v4 for a while, since it sounded you potentially had some
additional comments coming up?

Stefan

  reply	other threads:[~2013-11-26  6:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-22  4:34 [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver Stefan Kristiansson
2013-11-24 14:12 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-26  6:55   ` Stefan Kristiansson [this message]
2013-11-26  7:10 ` Michal Simek
2013-11-26  8:13   ` Stefan Kristiansson
2013-11-26  8:19   ` Geert Uytterhoeven
2013-11-26  8:22     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131126065551.GA2838@chokladfabriken.org \
    --to=stefan.kristiansson@saunalahti.fi \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).