From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv13][ 1/4] video: imxfb: Introduce regulator support.
Date: Fri, 06 Dec 2013 07:12:56 +0000 [thread overview]
Message-ID: <20131206071256.GX24559@pengutronix.de> (raw)
In-Reply-To: <1386258219-26437-1-git-send-email-denis@eukrea.com>
On Thu, Dec 05, 2013 at 04:43:36PM +0100, Denis Carikli wrote:
> This commit is based on the following commit by Fabio Estevam:
> @@ -1020,6 +1045,12 @@ static int imxfb_probe(struct platform_device *pdev)
> goto failed_register;
> }
>
> + fbi->reg_lcd = devm_regulator_get(&pdev->dev, "lcd");
> + if (IS_ERR(fbi->reg_lcd)) {
> + dev_info(&pdev->dev, "No lcd regulator used.\n");
Please remove this log spam or at least reduce it to dev_dbg. That's the
typical message to which our customers keep asking us whether that's
something they have to care about.
Also, you should check for -EPROBE_DEFER here and return it in this
case.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2013-12-06 7:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 15:43 [PATCHv13][ 1/4] video: imxfb: Introduce regulator support Denis Carikli
2013-12-05 15:43 ` [PATCHv13][ 2/4] video: imxfb: Also add pwmr for the device tree Denis Carikli
2013-12-05 15:53 ` [PATCHv13][ 2/4] video: imxfb: Also add p =?UTF-8?B?d21yIGZvciB0aGUgZ Alexander Shiyan
2013-12-06 7:05 ` [PATCHv13][ 2/4] video: imxfb: Also add pwmr for the device tree Sascha Hauer
2013-12-06 8:03 ` [PATCHv13][ 2/4] video: imxfb: Also add p =?UTF-8?B?d21yIGZvciB0aGUgZ Alexander Shiyan
2013-12-06 8:16 ` [PATCHv13][ 2/4] video: imxfb: Also add pwmr for the device tree Sascha Hauer
2013-12-06 8:35 ` [PATCHv13][ 2/4] video: imxfb: Also add p =?UTF-8?B?d21yIGZvciB0aGUgZ Alexander Shiyan
2013-12-06 9:30 ` [PATCHv13][ 2/4] video: imxfb: Also add pwmr for the device tree Sascha Hauer
2013-12-06 9:40 ` [PATCHv13][ 2/4] video: imxfb: Also add p =?UTF-8?B?d21yIGZvciB0aGUgZ Alexander Shiyan
2013-12-05 15:43 ` [PATCHv13][ 3/4] video: Kconfig: Allow more broad selection of the imxfb framebuffer driver Denis Carikli
2013-12-06 7:06 ` Sascha Hauer
2013-12-05 15:43 ` [PATCHv13][ 4/4] ARM: dts: imx25: mbimxsd25: Add displays support Denis Carikli
2013-12-06 7:12 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206071256.GX24559@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).