* [PATCH] drivers: video: Remove unused function genericbl_limit_intensity() in generic_bl.c
@ 2013-12-16 11:33 Rashika Kheria
2013-12-16 11:34 ` Jingoo Han
2013-12-16 14:24 ` Josh Triplett
0 siblings, 2 replies; 4+ messages in thread
From: Rashika Kheria @ 2013-12-16 11:33 UTC (permalink / raw)
To: linux-kernel
Cc: Jingoo Han, Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
linux-fbdev, josh
Removes unused function genericbl_limit_intensity() in
backlight/generic_bl.c.
This eliminates the following warning in backlight/generic_bl.c:
drivers/video/backlight/generic_bl.c:59:6: warning: no previous prototype for ‘genericbl_limit_intensity’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/video/backlight/generic_bl.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c
index 5d8d652..67dfb93 100644
--- a/drivers/video/backlight/generic_bl.c
+++ b/drivers/video/backlight/generic_bl.c
@@ -52,24 +52,6 @@ static int genericbl_get_intensity(struct backlight_device *bd)
return genericbl_intensity;
}
-/*
- * Called when the battery is low to limit the backlight intensity.
- * If limit=0 clear any limit, otherwise limit the intensity
- */
-void genericbl_limit_intensity(int limit)
-{
- struct backlight_device *bd = generic_backlight_device;
-
- mutex_lock(&bd->ops_lock);
- if (limit)
- bd->props.state |= GENERICBL_BATTLOW;
- else
- bd->props.state &= ~GENERICBL_BATTLOW;
- backlight_update_status(generic_backlight_device);
- mutex_unlock(&bd->ops_lock);
-}
-EXPORT_SYMBOL(genericbl_limit_intensity);
-
static const struct backlight_ops genericbl_ops = {
.options = BL_CORE_SUSPENDRESUME,
.get_brightness = genericbl_get_intensity,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: video: Remove unused function genericbl_limit_intensity() in generic_bl.c
2013-12-16 11:33 [PATCH] drivers: video: Remove unused function genericbl_limit_intensity() in generic_bl.c Rashika Kheria
@ 2013-12-16 11:34 ` Jingoo Han
2013-12-16 14:24 ` Josh Triplett
1 sibling, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-12-16 11:34 UTC (permalink / raw)
To: 'Eric Miao'
Cc: 'Rashika Kheria', linux-kernel,
'Jean-Christophe Plagniol-Villard',
'Tomi Valkeinen', linux-fbdev, 'Josh Triplett',
'Jingoo Han'
On Monday, December 16, 2013 8:21 PM, Rashika Kheria wrote:
>
> Removes unused function genericbl_limit_intensity() in
> backlight/generic_bl.c.
>
> This eliminates the following warning in backlight/generic_bl.c:
> drivers/video/backlight/generic_bl.c:59:6: warning: no previous prototype for
> ‘genericbl_limit_intensity’ [-Wmissing-prototypes]
Hi Eric,
Originally, genericbl_limit_intensity() was added by you.
(commit: bfdcaa3 "lcd: add corgibl_limit_intensity() to corgi_lcd")
Currently, genericbl_limit_intensity() is not called anywhere
in mainline kernel. Can we remove this genericbl_limit_intensity()?
Best regards,
Jingoo Han
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> ---
> drivers/video/backlight/generic_bl.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c
> index 5d8d652..67dfb93 100644
> --- a/drivers/video/backlight/generic_bl.c
> +++ b/drivers/video/backlight/generic_bl.c
> @@ -52,24 +52,6 @@ static int genericbl_get_intensity(struct backlight_device *bd)
> return genericbl_intensity;
> }
>
> -/*
> - * Called when the battery is low to limit the backlight intensity.
> - * If limit=0 clear any limit, otherwise limit the intensity
> - */
> -void genericbl_limit_intensity(int limit)
> -{
> - struct backlight_device *bd = generic_backlight_device;
> -
> - mutex_lock(&bd->ops_lock);
> - if (limit)
> - bd->props.state |= GENERICBL_BATTLOW;
> - else
> - bd->props.state &= ~GENERICBL_BATTLOW;
> - backlight_update_status(generic_backlight_device);
> - mutex_unlock(&bd->ops_lock);
> -}
> -EXPORT_SYMBOL(genericbl_limit_intensity);
> -
> static const struct backlight_ops genericbl_ops = {
> .options = BL_CORE_SUSPENDRESUME,
> .get_brightness = genericbl_get_intensity,
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: video: Remove unused function genericbl_limit_intensity() in generic_bl.c
2013-12-16 11:33 [PATCH] drivers: video: Remove unused function genericbl_limit_intensity() in generic_bl.c Rashika Kheria
2013-12-16 11:34 ` Jingoo Han
@ 2013-12-16 14:24 ` Josh Triplett
2013-12-27 2:21 ` Jingoo Han
1 sibling, 1 reply; 4+ messages in thread
From: Josh Triplett @ 2013-12-16 14:24 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Jingoo Han, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, linux-fbdev
On Mon, Dec 16, 2013 at 04:51:10PM +0530, Rashika Kheria wrote:
> Removes unused function genericbl_limit_intensity() in
> backlight/generic_bl.c.
>
> This eliminates the following warning in backlight/generic_bl.c:
> drivers/video/backlight/generic_bl.c:59:6: warning: no previous prototype for ‘genericbl_limit_intensity’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/video/backlight/generic_bl.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c
> index 5d8d652..67dfb93 100644
> --- a/drivers/video/backlight/generic_bl.c
> +++ b/drivers/video/backlight/generic_bl.c
> @@ -52,24 +52,6 @@ static int genericbl_get_intensity(struct backlight_device *bd)
> return genericbl_intensity;
> }
>
> -/*
> - * Called when the battery is low to limit the backlight intensity.
> - * If limit=0 clear any limit, otherwise limit the intensity
> - */
> -void genericbl_limit_intensity(int limit)
> -{
> - struct backlight_device *bd = generic_backlight_device;
> -
> - mutex_lock(&bd->ops_lock);
> - if (limit)
> - bd->props.state |= GENERICBL_BATTLOW;
> - else
> - bd->props.state &= ~GENERICBL_BATTLOW;
> - backlight_update_status(generic_backlight_device);
> - mutex_unlock(&bd->ops_lock);
> -}
> -EXPORT_SYMBOL(genericbl_limit_intensity);
> -
> static const struct backlight_ops genericbl_ops = {
> .options = BL_CORE_SUSPENDRESUME,
> .get_brightness = genericbl_get_intensity,
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: video: Remove unused function genericbl_limit_intensity() in generic_bl.c
2013-12-16 14:24 ` Josh Triplett
@ 2013-12-27 2:21 ` Jingoo Han
0 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-12-27 2:21 UTC (permalink / raw)
To: 'Rashika Kheria', 'Andrew Morton'
Cc: 'Josh Triplett', linux-kernel,
'Jean-Christophe Plagniol-Villard',
'Tomi Valkeinen', linux-fbdev, 'Jingoo Han',
'Eric Miao'
On Monday, December 16, 2013 11:24 PM, Josh Triplett wrote:
> On Mon, Dec 16, 2013 at 04:51:10PM +0530, Rashika Kheria wrote:
> > Removes unused function genericbl_limit_intensity() in
> > backlight/generic_bl.c.
> >
> > This eliminates the following warning in backlight/generic_bl.c:
> > drivers/video/backlight/generic_bl.c:59:6: warning: no previous prototype for
> ‘genericbl_limit_intensity’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
(+cc Andrew Morton, Eric Miao)
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
>
> > drivers/video/backlight/generic_bl.c | 18 ------------------
> > 1 file changed, 18 deletions(-)
> >
> > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c
> > index 5d8d652..67dfb93 100644
> > --- a/drivers/video/backlight/generic_bl.c
> > +++ b/drivers/video/backlight/generic_bl.c
> > @@ -52,24 +52,6 @@ static int genericbl_get_intensity(struct backlight_device *bd)
> > return genericbl_intensity;
> > }
> >
> > -/*
> > - * Called when the battery is low to limit the backlight intensity.
> > - * If limit=0 clear any limit, otherwise limit the intensity
> > - */
> > -void genericbl_limit_intensity(int limit)
> > -{
> > - struct backlight_device *bd = generic_backlight_device;
> > -
> > - mutex_lock(&bd->ops_lock);
> > - if (limit)
> > - bd->props.state |= GENERICBL_BATTLOW;
> > - else
> > - bd->props.state &= ~GENERICBL_BATTLOW;
> > - backlight_update_status(generic_backlight_device);
> > - mutex_unlock(&bd->ops_lock);
> > -}
> > -EXPORT_SYMBOL(genericbl_limit_intensity);
> > -
> > static const struct backlight_ops genericbl_ops = {
> > .options = BL_CORE_SUSPENDRESUME,
> > .get_brightness = genericbl_get_intensity,
> > --
> > 1.7.9.5
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-27 2:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-16 11:33 [PATCH] drivers: video: Remove unused function genericbl_limit_intensity() in generic_bl.c Rashika Kheria
2013-12-16 11:34 ` Jingoo Han
2013-12-16 14:24 ` Josh Triplett
2013-12-27 2:21 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).