linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: linux-fbdev@vger.kernel.org, gregkh@linuxfoundation.org,
	jasowang@redhat.com, linux-kernel@vger.kernel.org,
	tomi.valkeinen@ti.com,
	"open list:Hyper-V CORE AND..." <devel@linuxdriverproject.org>,
	haiyangz@microsoft.com
Subject: Re: [PATCH v2 1/5] Drivers: hv: vmbus: Extract the mmio information from DSDT
Date: Mon, 24 Feb 2014 10:36:24 +0000	[thread overview]
Message-ID: <20140224103623.GF26722@mwanda> (raw)
In-Reply-To: <1393237516-28545-2-git-send-email-kraxel@redhat.com>

On Mon, Feb 24, 2014 at 11:25:12AM +0100, Gerd Hoffmann wrote:
> -static acpi_status vmbus_walk_resources(struct acpi_resource *res, void *irq)
> +static acpi_status vmbus_walk_resources(struct acpi_resource *res, void *ctx)
>  {
> +	switch (res->type) {
> +	case ACPI_RESOURCE_TYPE_IRQ:
> +		irq = res->data.irq.interrupts[0];
>  
> -	if (res->type = ACPI_RESOURCE_TYPE_IRQ) {
> -		struct acpi_resource_irq *irqp;
> -		irqp = &res->data.irq;
> -
> -		*((unsigned int *)irq) = irqp->interrupts[0];

Add a /* fall through */ comment here.

> +	case ACPI_RESOURCE_TYPE_ADDRESS64:
> +		hyperv_mmio_start = res->data.address64.minimum;
> +		hyperv_mmio_size = res->data.address64.address_length;
>  	}

regards,
dan carpenter


  reply	other threads:[~2014-02-24 10:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24 10:25 [PATCH v2 0/5] hyperv-fb: add support for generation 2 virtual machines Gerd Hoffmann
2014-02-24 10:25 ` [PATCH v2 1/5] Drivers: hv: vmbus: Extract the mmio information from DSDT Gerd Hoffmann
2014-02-24 10:36   ` Dan Carpenter [this message]
2014-02-24 10:25 ` [PATCH v2 2/5] vmbus: add missing breaks Gerd Hoffmann
2014-02-24 10:42   ` Dan Carpenter
2014-02-24 10:55     ` Gerd Hoffmann
2014-02-24 11:07       ` Dan Carpenter
2014-02-24 10:25 ` [PATCH v2 3/5] vmbus: use resource for hyperv mmio region Gerd Hoffmann
2014-02-24 10:25 ` [PATCH v2 4/5] hyperv-fb: add support for generation 2 virtual machines Gerd Hoffmann
2014-02-24 10:25 ` [PATCH v2 5/5] hyperv-fb: kick off efifb early Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140224103623.GF26722@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).