* [PATCH] fbdev: FB_OPENCORES should depend on HAS_DMA
@ 2014-02-21 19:56 Geert Uytterhoeven
2014-03-05 10:01 ` Stefan Kristiansson
2014-03-05 12:44 ` Tomi Valkeinen
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-02-21 19:56 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
Stefan Kristiansson
Cc: linux-fbdev, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
drivers/built-in.o: In function `ocfb_remove':
ocfb.c:(.text+0x27fee): undefined reference to `dma_free_coherent'
drivers/built-in.o: In function `ocfb_probe':
ocfb.c:(.text+0x28418): undefined reference to `dma_alloc_coherent'
ocfb.c:(.text+0x284d2): undefined reference to `dma_free_coherent'
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/video/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 0192900dd183..fb8d31e717bc 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -982,7 +982,7 @@ config FB_PVR2
config FB_OPENCORES
tristate "OpenCores VGA/LCD core 2.0 framebuffer support"
- depends on FB
+ depends on FB && HAS_DMA
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] fbdev: FB_OPENCORES should depend on HAS_DMA
2014-02-21 19:56 [PATCH] fbdev: FB_OPENCORES should depend on HAS_DMA Geert Uytterhoeven
@ 2014-03-05 10:01 ` Stefan Kristiansson
2014-03-05 12:44 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Kristiansson @ 2014-03-05 10:01 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev,
linux-kernel
On Fri, Feb 21, 2014 at 08:56:09PM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `ocfb_remove':
> ocfb.c:(.text+0x27fee): undefined reference to `dma_free_coherent'
> drivers/built-in.o: In function `ocfb_probe':
> ocfb.c:(.text+0x28418): undefined reference to `dma_alloc_coherent'
> ocfb.c:(.text+0x284d2): undefined reference to `dma_free_coherent'
>
I obviously had neglected compiling against that configuration,
thanks for the catch.
Acked-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/video/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 0192900dd183..fb8d31e717bc 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -982,7 +982,7 @@ config FB_PVR2
>
> config FB_OPENCORES
> tristate "OpenCores VGA/LCD core 2.0 framebuffer support"
> - depends on FB
> + depends on FB && HAS_DMA
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fbdev: FB_OPENCORES should depend on HAS_DMA
2014-02-21 19:56 [PATCH] fbdev: FB_OPENCORES should depend on HAS_DMA Geert Uytterhoeven
2014-03-05 10:01 ` Stefan Kristiansson
@ 2014-03-05 12:44 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2014-03-05 12:44 UTC (permalink / raw)
To: Geert Uytterhoeven, Stefan Kristiansson
Cc: Jean-Christophe Plagniol-Villard, linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
On 21/02/14 21:56, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `ocfb_remove':
> ocfb.c:(.text+0x27fee): undefined reference to `dma_free_coherent'
> drivers/built-in.o: In function `ocfb_probe':
> ocfb.c:(.text+0x28418): undefined reference to `dma_alloc_coherent'
> ocfb.c:(.text+0x284d2): undefined reference to `dma_free_coherent'
>
Thanks, applied to fbdev branch.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-05 12:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-21 19:56 [PATCH] fbdev: FB_OPENCORES should depend on HAS_DMA Geert Uytterhoeven
2014-03-05 10:01 ` Stefan Kristiansson
2014-03-05 12:44 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).