From: Lee Jones <lee.jones@linaro.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/2] backlight: platform_lcd: Remove #ifdef CONFIG_PM_SLEEP
Date: Mon, 31 Mar 2014 07:43:40 +0000 [thread overview]
Message-ID: <20140331074340.GL17779@lee--X1> (raw)
In-Reply-To: <1396087220-1564-2-git-send-email-shc_work@mail.ru>
> This patch removes #ifdef CONFIG_PM_SLEEP to improve compile coverage.
Compile coverage would improve if we removed all in-file CONFIG
stipulations, but that's not helpful. What's the reason for removing
them in this case?
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> drivers/video/backlight/platform_lcd.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c
> index 4afc21f..986f46a 100644
> --- a/drivers/video/backlight/platform_lcd.c
> +++ b/drivers/video/backlight/platform_lcd.c
> @@ -110,8 +110,7 @@ static int platform_lcd_probe(struct platform_device *pdev)
> return 0;
> }
>
> -#ifdef CONFIG_PM_SLEEP
> -static int platform_lcd_suspend(struct device *dev)
> +static int __maybe_unused platform_lcd_suspend(struct device *dev)
> {
> struct platform_lcd *plcd = dev_get_drvdata(dev);
>
> @@ -121,7 +120,7 @@ static int platform_lcd_suspend(struct device *dev)
> return 0;
> }
>
> -static int platform_lcd_resume(struct device *dev)
> +static int __maybe_unused platform_lcd_resume(struct device *dev)
> {
> struct platform_lcd *plcd = dev_get_drvdata(dev);
>
> @@ -130,7 +129,6 @@ static int platform_lcd_resume(struct device *dev)
>
> return 0;
> }
> -#endif
>
> static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend,
> platform_lcd_resume);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-03-31 7:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-29 10:00 [PATCH 2/2] backlight: platform_lcd: Remove #ifdef CONFIG_PM_SLEEP Alexander Shiyan
2014-03-31 7:43 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331074340.GL17779@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).