linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: re: video: pxa3xx-gcu: switch to devres functions
Date: Wed, 02 Apr 2014 11:15:19 +0000	[thread overview]
Message-ID: <20140402111519.GC23000@mwanda> (raw)

Hello Daniel Mack,

The patch a9b47c7f2390: "video: pxa3xx-gcu: switch to devres
functions" from Mar 5, 2014, leads to the following static checker
warning:

	drivers/video/fbdev/pxa3xx-gcu.c:616 pxa3xx_gcu_probe()
	warn: 'priv->mmio_base' isn't an ERR_PTR

drivers/video/fbdev/pxa3xx-gcu.c
   612  
   613          /* handle IO resources */
   614          r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
   615          priv->mmio_base = devm_request_and_ioremap(dev, r);
   616          if (IS_ERR(priv->mmio_base)) {

devm_request_and_ioremap() returns NULL on error.

   617                  dev_err(dev, "failed to map I/O memory\n");
   618                  return PTR_ERR(priv->mmio_base);
   619          }
   620  

regards,
dan carpenter

             reply	other threads:[~2014-04-02 11:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02 11:15 Dan Carpenter [this message]
2014-04-03  0:04 ` video: pxa3xx-gcu: switch to devres functions Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140402111519.GC23000@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).