[PATCH] fbdev: Fix tmiofb driver dependencies

[PATCH] fbdev: Fix tmiofb driver dependencies

[Jean Delvare]

The tmiofb driver should not depend on MFD_CORE but on MFD_TMIO.
Without the tmio_core driver, tmiofb has no platform device to bind
to and is thus useless.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
I suspect that MFD_TMIO was originally intended and MFD_CORE was a
typo.

 drivers/video/fbdev/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-3.15-rc2.orig/drivers/video/fbdev/Kconfig	2014-04-23 11:51:17.163933232 +0200
+++ linux-3.15-rc2/drivers/video/fbdev/Kconfig	2014-04-23 13:40:01.170774059 +0200
@@ -1993,7 +1993,7 @@ config FB_SH_MOBILE_HDMI
 
 config FB_TMIO
 	tristate "Toshiba Mobile IO FrameBuffer support"
-	depends on FB && MFD_CORE
+	depends on FB && MFD_TMIO
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT

-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] fbdev: Fix tmiofb driver dependencies

[Geert Uytterhoeven]

Hi Jean,

On Wed, Apr 23, 2014 at 1:51 PM, Jean Delvare <jdelvare@suse.de> wrote:
> The tmiofb driver should not depend on MFD_CORE but on MFD_TMIO.
> Without the tmio_core driver, tmiofb has no platform device to bind
> to and is thus useless.

What about COMPILE_TEST?

> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> I suspect that MFD_TMIO was originally intended and MFD_CORE was a
> typo.

Does it compile with MFD_CORE=n?
If no: depends on FB && MDF_CORE && (MFD_TMIO || COMPILE_TEST)
If yes: depends on FB && (MFD_TMIO || COMPILE_TEST)

>  drivers/video/fbdev/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-3.15-rc2.orig/drivers/video/fbdev/Kconfig     2014-04-23 11:51:17.163933232 +0200
> +++ linux-3.15-rc2/drivers/video/fbdev/Kconfig  2014-04-23 13:40:01.170774059 +0200
> @@ -1993,7 +1993,7 @@ config FB_SH_MOBILE_HDMI
>
>  config FB_TMIO
>         tristate "Toshiba Mobile IO FrameBuffer support"
> -       depends on FB && MFD_CORE
> +       depends on FB && MFD_TMIO

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] fbdev: Fix tmiofb driver dependencies

[Jean Delvare]

Hi Geert,

On Wed, 23 Apr 2014 21:45:45 +0200, Geert Uytterhoeven wrote:
> On Wed, Apr 23, 2014 at 1:51 PM, Jean Delvare <jdelvare@suse.de> wrote:
> > The tmiofb driver should not depend on MFD_CORE but on MFD_TMIO.
> > Without the tmio_core driver, tmiofb has no platform device to bind
> > to and is thus useless.
> 
> What about COMPILE_TEST?

I could add that, yes, good point.

> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > ---
> > I suspect that MFD_TMIO was originally intended and MFD_CORE was a
> > typo.
> 
> Does it compile with MFD_CORE=n?

I tried and yes, it does.

> If no: depends on FB && MDF_CORE && (MFD_TMIO || COMPILE_TEST)
> If yes: depends on FB && (MFD_TMIO || COMPILE_TEST)

I'll send an updated patch doing the latter.

Thanks for the review,
-- 
Jean Delvare
SUSE L3 Support