* re: OMAPDSS: panel sharp-ls037v7dw01 DT support
@ 2014-06-10 9:04 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-06-10 9:04 UTC (permalink / raw)
To: linux-fbdev
Hello Tony Lindgren,
This is a semi-automatic email about new static checker warnings.
The patch be88c16a22ed: "OMAPDSS: panel sharp-ls037v7dw01 DT support"
from May 16, 2014, leads to the following Smatch complaint:
drivers/video/fbdev/omap2/displays-new/panel-sharp-ls037v7dw01.c:113 sharp_ls_enable()
error: we previously assumed 'ddata->vcc' could be null (see line 105)
drivers/video/fbdev/omap2/displays-new/panel-sharp-ls037v7dw01.c
104
105 if (ddata->vcc) {
^^^^^^^^^^
Patch introduces a check.
106 r = regulator_enable(ddata->vcc);
107 if (r != 0)
108 return r;
109 }
110
111 r = in->ops.dpi->enable(in);
112 if (r) {
113 regulator_disable(ddata->vcc);
^^^^^^^^^^
Patch introduces a new dereference and I was too lazy to find out if
an error in ->enable() implies a non-null "ddata->vcc" because I am a
bad person.
114 return r;
115 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-06-10 9:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-10 9:04 OMAPDSS: panel sharp-ls037v7dw01 DT support Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).