[PATCH] pwm-backlight: use devm_gpiod_get_optional()

[PATCH] pwm-backlight: use devm_gpiod_get_optional()

[Alexandre Courbot]

Make use of the new devm_gpiod_get_optional() to simplify the probe
code.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 drivers/video/backlight/pwm_bl.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 38ca88bc5c3e..d1e0a7c6cac7 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -245,13 +245,10 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 	pb->dev = &pdev->dev;
 	pb->enabled = false;
 
-	pb->enable_gpio = devm_gpiod_get(&pdev->dev, "enable");
+	pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable");
 	if (IS_ERR(pb->enable_gpio)) {
 		ret = PTR_ERR(pb->enable_gpio);
-		if (ret = -ENOENT)
-			pb->enable_gpio = NULL;
-		else
-			goto err_alloc;
+		goto err_alloc;
 	}
 
 	/*
-- 
2.0.0

Re: [PATCH] pwm-backlight: use devm_gpiod_get_optional()

[Lee Jones]

> Make use of the new devm_gpiod_get_optional() to simplify the probe
> code.
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
>  drivers/video/backlight/pwm_bl.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Looks good.  Applied, thanks.

> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 38ca88bc5c3e..d1e0a7c6cac7 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -245,13 +245,10 @@ static int pwm_backlight_probe(struct platform_device *pdev)
>  	pb->dev = &pdev->dev;
>  	pb->enabled = false;
>  
> -	pb->enable_gpio = devm_gpiod_get(&pdev->dev, "enable");
> +	pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable");
>  	if (IS_ERR(pb->enable_gpio)) {
>  		ret = PTR_ERR(pb->enable_gpio);
> -		if (ret = -ENOENT)
> -			pb->enable_gpio = NULL;
> -		else
> -			goto err_alloc;
> +		goto err_alloc;
>  	}
>  
>  	/*

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] pwm-backlight: use devm_gpiod_get_optional()

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]

On Wed, Jun 25, 2014 at 10:54:47AM +0100, Lee Jones wrote:
> > Make use of the new devm_gpiod_get_optional() to simplify the probe
> > code.
> > 
> > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> > ---
> >  drivers/video/backlight/pwm_bl.c | 7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> Looks good.  Applied, thanks.

Technically pwm_bl.c is my turf. However I only adopted it way back when
the backlight subsystem was orphaned, but it seems Jingoo, Bryan and you
are taking good care of it these days, so perhaps it would be a good
idea to move it back to your custody?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] pwm-backlight: use devm_gpiod_get_optional()

[Lee Jones]

On Wed, 25 Jun 2014, Thierry Reding wrote:
> On Wed, Jun 25, 2014 at 10:54:47AM +0100, Lee Jones wrote:
> > > Make use of the new devm_gpiod_get_optional() to simplify the probe
> > > code.
> > > 
> > > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> > > ---
> > >  drivers/video/backlight/pwm_bl.c | 7 ++-----
> > >  1 file changed, 2 insertions(+), 5 deletions(-)
> > 
> > Looks good.  Applied, thanks.
> 
> Technically pwm_bl.c is my turf. However I only adopted it way back when
> the backlight subsystem was orphaned, but it seems Jingoo, Bryan and you
> are taking good care of it these days, so perhaps it would be a good
> idea to move it back to your custody?

Yeah, the whole 'driver maintainer' sketch could get pretty complex.
It's pretty clean-cut in the PWM subsystem as only one exists, but
Backlight and MFD have a whole bunch, and I don't usually wait for
them to Ack/Nack before applying or providing review comments.

I'm happy to play it however you like really.  I'm sure the boys and I
can handle it if you so wish.  Even better if you would say in the
MAINTAINERS file and provide review comments when patches are
submitted.  I do think all 'drivers/video/backlight' changes should go
in via the Backlight tree though.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] pwm-backlight: use devm_gpiod_get_optional()

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

On Wed, Jun 25, 2014 at 01:03:31PM +0100, Lee Jones wrote:
> On Wed, 25 Jun 2014, Thierry Reding wrote:
> > On Wed, Jun 25, 2014 at 10:54:47AM +0100, Lee Jones wrote:
> > > > Make use of the new devm_gpiod_get_optional() to simplify the probe
> > > > code.
> > > > 
> > > > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> > > > ---
> > > >  drivers/video/backlight/pwm_bl.c | 7 ++-----
> > > >  1 file changed, 2 insertions(+), 5 deletions(-)
> > > 
> > > Looks good.  Applied, thanks.
> > 
> > Technically pwm_bl.c is my turf. However I only adopted it way back when
> > the backlight subsystem was orphaned, but it seems Jingoo, Bryan and you
> > are taking good care of it these days, so perhaps it would be a good
> > idea to move it back to your custody?
> 
> Yeah, the whole 'driver maintainer' sketch could get pretty complex.
> It's pretty clean-cut in the PWM subsystem as only one exists, but
> Backlight and MFD have a whole bunch, and I don't usually wait for
> them to Ack/Nack before applying or providing review comments.
> 
> I'm happy to play it however you like really.  I'm sure the boys and I
> can handle it if you so wish.  Even better if you would say in the
> MAINTAINERS file and provide review comments when patches are
> submitted.  I do think all 'drivers/video/backlight' changes should go
> in via the Backlight tree though.

Okay, that works for me.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]