* [PATCH] video: fbdev: mxsfb.c: Cleaning up variable that is never used
@ 2014-07-05 12:33 Rickard Strandqvist
2014-07-06 18:44 ` Rickard Strandqvist
0 siblings, 1 reply; 3+ messages in thread
From: Rickard Strandqvist @ 2014-07-05 12:33 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Rickard Strandqvist, Grant Likely,
Rob Herring, Maxime Ripard, Lothar Waßmann, Jingoo Han,
Fabio Estevam, Julia Lawall, Marek Vasut,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/mxsfb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/mxsfb.c b/drivers/video/fbdev/mxsfb.c
index accf48a2..d0a55c6 100644
--- a/drivers/video/fbdev/mxsfb.c
+++ b/drivers/video/fbdev/mxsfb.c
@@ -594,7 +594,6 @@ static int mxsfb_restore_mode(struct mxsfb_info *host,
struct fb_videomode *vmode)
{
struct fb_info *fb_info = &host->fb_info;
- unsigned line_count;
unsigned period;
unsigned long pa, fbsize;
int bits_per_pixel, ofs;
@@ -672,7 +671,6 @@ static int mxsfb_restore_mode(struct mxsfb_info *host,
writel(fb_info->fix.smem_start, host->base + host->devdata->next_buf);
}
- line_count = fb_info->fix.smem_len / fb_info->fix.line_length;
fb_info->fix.ypanstep = 1;
clk_prepare_enable(host->clk);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] video: fbdev: mxsfb.c: Cleaning up variable that is never used
2014-07-05 12:33 [PATCH] video: fbdev: mxsfb.c: Cleaning up variable that is never used Rickard Strandqvist
@ 2014-07-06 18:44 ` Rickard Strandqvist
2014-07-06 21:06 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Rickard Strandqvist @ 2014-07-06 18:44 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Grant Likely, Rob Herring, Maxime Ripard,
Lothar Waßmann, Jingoo Han, Fabio Estevam, Julia Lawall,
Marek Vasut, linux-fbdev, linux-kernel, devicetree
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/mxsfb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/mxsfb.c b/drivers/video/fbdev/mxsfb.c
index accf48a2..d0a55c6 100644
--- a/drivers/video/fbdev/mxsfb.c
+++ b/drivers/video/fbdev/mxsfb.c
@@ -594,7 +594,6 @@ static int mxsfb_restore_mode(struct mxsfb_info *host,
struct fb_videomode *vmode)
{
struct fb_info *fb_info = &host->fb_info;
- unsigned line_count;
unsigned period;
unsigned long pa, fbsize;
int bits_per_pixel, ofs;
@@ -672,7 +671,6 @@ static int mxsfb_restore_mode(struct mxsfb_info *host,
writel(fb_info->fix.smem_start, host->base + host->devdata->next_buf);
}
- line_count = fb_info->fix.smem_len / fb_info->fix.line_length;
fb_info->fix.ypanstep = 1;
clk_prepare_enable(host->clk);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] video: fbdev: mxsfb.c: Cleaning up variable that is never used
2014-07-06 18:44 ` Rickard Strandqvist
@ 2014-07-06 21:06 ` Marek Vasut
0 siblings, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2014-07-06 21:06 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Grant Likely,
Rob Herring, Maxime Ripard, Lothar Waßmann, Jingoo Han,
Fabio Estevam, Julia Lawall, linux-fbdev, linux-kernel,
devicetree
On Sunday, July 06, 2014 at 08:44:32 PM, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Makes perfect sense.
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-06 21:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-05 12:33 [PATCH] video: fbdev: mxsfb.c: Cleaning up variable that is never used Rickard Strandqvist
2014-07-06 18:44 ` Rickard Strandqvist
2014-07-06 21:06 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).