From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Mon, 07 Jul 2014 10:46:35 +0000 Subject: Re: [PATCH] video: backlight: jornada720_lcd.c: Cleaning up variable that is never used Message-Id: <20140707104635.GA6407@lee--X1> List-Id: References: <1404670906-17335-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1404670906-17335-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Rickard Strandqvist Cc: Jingoo Han , Bryan Wu , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. >=20 > This was found using a static code analysis program called cppcheck >=20 > Signed-off-by: Rickard Strandqvist > --- > drivers/video/backlight/jornada720_lcd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Solve it the other way around. Add a check and return the value if an error is returned. > diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/bac= klight/jornada720_lcd.c > index da3876c..b304319 100644 > --- a/drivers/video/backlight/jornada720_lcd.c > +++ b/drivers/video/backlight/jornada720_lcd.c > @@ -56,12 +56,10 @@ static int jornada_lcd_get_contrast(struct lcd_device= *ld) > =20 > static int jornada_lcd_set_contrast(struct lcd_device *ld, int value) > { > - int ret; > - > jornada_ssp_start(); > =20 > /* start by sending our set contrast cmd to mcu */ > - ret =3D jornada_ssp_byte(SETCONTRAST); > + jornada_ssp_byte(SETCONTRAST); > =20 > /* push the new value */ > if (jornada_ssp_byte(value) !=3D TXDUMMY) { --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog