* [PATCH] video: backlight: ili922x.c: Cleaning up variable that is never used
@ 2014-07-05 12:11 Rickard Strandqvist
2014-07-06 18:20 ` Rickard Strandqvist
2014-07-07 10:50 ` Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: Rickard Strandqvist @ 2014-07-05 12:11 UTC (permalink / raw)
To: Jingoo Han, Bryan Wu
Cc: Rickard Strandqvist, Rickard Strandqvist, Lee Jones,
Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev,
linux-kernel
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/backlight/ili922x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c
index ea67fe1..06936c8 100644
--- a/drivers/video/backlight/ili922x.c
+++ b/drivers/video/backlight/ili922x.c
@@ -251,7 +251,7 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value)
struct spi_transfer xfer_regindex, xfer_regvalue;
unsigned char tbuf[CMD_BUFSIZE];
unsigned char rbuf[CMD_BUFSIZE];
- int ret, len = 0;
+ int ret;
memset(&xfer_regindex, 0, sizeof(struct spi_transfer));
memset(&xfer_regvalue, 0, sizeof(struct spi_transfer));
@@ -273,7 +273,6 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value)
ret = spi_sync(spi, &msg);
spi_message_init(&msg);
- len = 0;
tbuf[0] = set_tx_byte(START_BYTE(ili922x_id, START_RS_REG,
START_RW_WRITE));
tbuf[1] = set_tx_byte((value & 0xFF00) >> 8);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] video: backlight: ili922x.c: Cleaning up variable that is never used
2014-07-05 12:11 [PATCH] video: backlight: ili922x.c: Cleaning up variable that is never used Rickard Strandqvist
@ 2014-07-06 18:20 ` Rickard Strandqvist
2014-07-07 10:48 ` Lee Jones
2014-07-07 10:50 ` Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Rickard Strandqvist @ 2014-07-06 18:20 UTC (permalink / raw)
To: Jingoo Han, Bryan Wu
Cc: Rickard Strandqvist, Lee Jones, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, linux-fbdev, linux-kernel
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/backlight/ili922x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c
index ea67fe1..06936c8 100644
--- a/drivers/video/backlight/ili922x.c
+++ b/drivers/video/backlight/ili922x.c
@@ -251,7 +251,7 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value)
struct spi_transfer xfer_regindex, xfer_regvalue;
unsigned char tbuf[CMD_BUFSIZE];
unsigned char rbuf[CMD_BUFSIZE];
- int ret, len = 0;
+ int ret;
memset(&xfer_regindex, 0, sizeof(struct spi_transfer));
memset(&xfer_regvalue, 0, sizeof(struct spi_transfer));
@@ -273,7 +273,6 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value)
ret = spi_sync(spi, &msg);
spi_message_init(&msg);
- len = 0;
tbuf[0] = set_tx_byte(START_BYTE(ili922x_id, START_RS_REG,
START_RW_WRITE));
tbuf[1] = set_tx_byte((value & 0xFF00) >> 8);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] video: backlight: ili922x.c: Cleaning up variable that is never used
2014-07-06 18:20 ` Rickard Strandqvist
@ 2014-07-07 10:48 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2014-07-07 10:48 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Jingoo Han, Bryan Wu, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, linux-fbdev, linux-kernel
On Sun, 06 Jul 2014, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/video/backlight/ili922x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c
> index ea67fe1..06936c8 100644
> --- a/drivers/video/backlight/ili922x.c
> +++ b/drivers/video/backlight/ili922x.c
> @@ -251,7 +251,7 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value)
> struct spi_transfer xfer_regindex, xfer_regvalue;
> unsigned char tbuf[CMD_BUFSIZE];
> unsigned char rbuf[CMD_BUFSIZE];
> - int ret, len = 0;
> + int ret;
>
> memset(&xfer_regindex, 0, sizeof(struct spi_transfer));
> memset(&xfer_regvalue, 0, sizeof(struct spi_transfer));
> @@ -273,7 +273,6 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value)
> ret = spi_sync(spi, &msg);
>
> spi_message_init(&msg);
> - len = 0;
> tbuf[0] = set_tx_byte(START_BYTE(ili922x_id, START_RS_REG,
> START_RW_WRITE));
> tbuf[1] = set_tx_byte((value & 0xFF00) >> 8);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] video: backlight: ili922x.c: Cleaning up variable that is never used
2014-07-05 12:11 [PATCH] video: backlight: ili922x.c: Cleaning up variable that is never used Rickard Strandqvist
2014-07-06 18:20 ` Rickard Strandqvist
@ 2014-07-07 10:50 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2014-07-07 10:50 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Jingoo Han, Bryan Wu, Rickard Strandqvist,
Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev,
linux-kernel
On Sat, 05 Jul 2014, Rickard Strandqvist wrote:
> From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
>
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/video/backlight/ili922x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Is this different from the patch I just applied?
> diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c
> index ea67fe1..06936c8 100644
> --- a/drivers/video/backlight/ili922x.c
> +++ b/drivers/video/backlight/ili922x.c
> @@ -251,7 +251,7 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value)
> struct spi_transfer xfer_regindex, xfer_regvalue;
> unsigned char tbuf[CMD_BUFSIZE];
> unsigned char rbuf[CMD_BUFSIZE];
> - int ret, len = 0;
> + int ret;
>
> memset(&xfer_regindex, 0, sizeof(struct spi_transfer));
> memset(&xfer_regvalue, 0, sizeof(struct spi_transfer));
> @@ -273,7 +273,6 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value)
> ret = spi_sync(spi, &msg);
>
> spi_message_init(&msg);
> - len = 0;
> tbuf[0] = set_tx_byte(START_BYTE(ili922x_id, START_RS_REG,
> START_RW_WRITE));
> tbuf[1] = set_tx_byte((value & 0xFF00) >> 8);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-07 10:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-05 12:11 [PATCH] video: backlight: ili922x.c: Cleaning up variable that is never used Rickard Strandqvist
2014-07-06 18:20 ` Rickard Strandqvist
2014-07-07 10:48 ` Lee Jones
2014-07-07 10:50 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).