Re: [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Mon, Jul 07, 2014 at 11:20:39AM +0100, Stefano Stabellini wrote:
> On Sun, 6 Jul 2014, Rickard Strandqvist wrote:
> > Remove assignment of function parameter, that has no effect outside the function
> > 
> > This was found using a static code analysis program called cppcheck
> > 
> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> 
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

and Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> 
> >  drivers/video/fbdev/xen-fbfront.c |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> > index 901014b..e1207a1 100644
> > --- a/drivers/video/fbdev/xen-fbfront.c
> > +++ b/drivers/video/fbdev/xen-fbfront.c
> > @@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green,
> >  	red = CNVT_TOHW(red, info->var.red.length);
> >  	green = CNVT_TOHW(green, info->var.green.length);
> >  	blue = CNVT_TOHW(blue, info->var.blue.length);
> > -	transp = CNVT_TOHW(transp, info->var.transp.length);
> >  #undef CNVT_TOHW
> >  
> >  	v = (red << info->var.red.offset) |
> > -- 
> > 1.7.10.4
> >