From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Date: Tue, 08 Jul 2014 15:08:12 +0000 Subject: Re: [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter Message-Id: <20140708150812.GC2863@laptop.dumpdata.com> List-Id: References: <1404667640-14855-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Stefano Stabellini Cc: Rickard Strandqvist , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Jingoo Han , Daniel Vetter , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Jul 07, 2014 at 11:20:39AM +0100, Stefano Stabellini wrote: > On Sun, 6 Jul 2014, Rickard Strandqvist wrote: > > Remove assignment of function parameter, that has no effect outside the function > > > > This was found using a static code analysis program called cppcheck > > > > Signed-off-by: Rickard Strandqvist > > Acked-by: Stefano Stabellini and Reviewed-by: Konrad Rzeszutek Wilk > > > > drivers/video/fbdev/xen-fbfront.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c > > index 901014b..e1207a1 100644 > > --- a/drivers/video/fbdev/xen-fbfront.c > > +++ b/drivers/video/fbdev/xen-fbfront.c > > @@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green, > > red = CNVT_TOHW(red, info->var.red.length); > > green = CNVT_TOHW(green, info->var.green.length); > > blue = CNVT_TOHW(blue, info->var.blue.length); > > - transp = CNVT_TOHW(transp, info->var.transp.length); > > #undef CNVT_TOHW > > > > v = (red << info->var.red.offset) | > > -- > > 1.7.10.4 > >