From: Greg KH <greg@kroah.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-mips@linux-mips.org, linux-fbdev@vger.kernel.org,
linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
Benoit Taine <benoit.taine@lip6.fr>,
ath5k-devel@venema.h4ckr.net, linux-acenic@sunsite.dk,
linux-scsi@vger.kernel.org, users@rt2x00.serialmonkey.com,
linux-rdma@vger.kernel.org, ath10k@lists.infradead.org,
linux-hippi@sunsite.dk, industrypack-devel@lists.sourceforge.net,
linux-wireless@vger.kernel.org, xen-devel@lists.xenproject.org,
MPT-FusionLinux.pdl@avagotech.com, ath9k-devel@venema.h4ckr.net,
wil6210@qca.qualcomm.com, linux-pcmcia@lists.infradead.org,
linux-can@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net,
linux-crypto@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
Date: Fri, 18 Jul 2014 16:43:40 +0000 [thread overview]
Message-ID: <20140718164340.GA24960@kroah.com> (raw)
In-Reply-To: <20140718162213.GC31114@tuxdriver.com>
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
> On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> > We should prefer `const struct pci_device_id` over
> > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> > This issue was reported by checkpatch.
>
> Honestly, I prefer the macro -- it stands-out more. Maybe the style
> guidelines and/or checkpatch should change instead?
The macro is horrid, no other bus has this type of thing just to save a
few characters in typing, so why should PCI be "special" in this regard
anymore?
thanks,
greg k-h
next prev parent reply other threads:[~2014-07-18 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 15:26 [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use Benoit Taine
2014-07-18 16:22 ` John W. Linville
2014-07-18 16:43 ` Greg KH [this message]
2014-07-18 16:54 ` James Bottomley
2014-07-18 18:17 ` Greg KH
2014-07-18 18:50 ` James Bottomley
2014-07-18 18:05 ` Joe Perches
2014-07-18 16:28 ` James Bottomley
2014-07-21 4:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718164340.GA24960@kroah.com \
--to=greg@kroah.com \
--cc=MPT-FusionLinux.pdl@avagotech.com \
--cc=ath10k@lists.infradead.org \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=benoit.taine@lip6.fr \
--cc=devel@linuxdriverproject.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=e1000-devel@lists.sourceforge.net \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=linux-acenic@sunsite.dk \
--cc=linux-can@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hippi@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wil6210@qca.qualcomm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).