From: Pavel Machek <pavel@ucw.cz>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Rickard Strandqvist <rickard.strandqvist@sonymobile.com>,
Wang YanQing <udknight@gmail.com>,
Jingoo Han <jg1.han@samsung.com>,
Evgeniy Polyakov <zbr@ioremap.net>, Joe Perches <joe@perches.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
David Fries <David@Fries.net>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: uvesafb.c: Cleaning up variable that is never used
Date: Mon, 21 Jul 2014 21:25:27 +0000 [thread overview]
Message-ID: <20140721212527.GC3824@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1404564682-21983-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sat 2014-07-05 14:51:22, Rickard Strandqvist wrote:
> From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
>
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
Are you sure this is right fix?
Should we be returning the error when there's error?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-07-21 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 12:51 [PATCH] video: fbdev: uvesafb.c: Cleaning up variable that is never used Rickard Strandqvist
2014-07-06 19:01 ` Rickard Strandqvist
2014-07-21 21:25 ` Pavel Machek [this message]
[not found] ` <CAFo99gYhrNR68mdJY=fn1x-+4U=6gdv=C4-Xn-w-YJAPSa5bBQ@mail.gmail.com>
2014-07-22 9:27 ` Pavel Machek
2014-07-23 20:37 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721212527.GC3824@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=David@Fries.net \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rickard.strandqvist@sonymobile.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=sachin.kamat@linaro.org \
--cc=tomi.valkeinen@ti.com \
--cc=udknight@gmail.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).