From: Pavel Machek <pavel@ucw.cz>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Joe Perches <joe@perches.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
Evgeniy Polyakov <zbr@ioremap.net>,
Wang YanQing <udknight@gmail.com>,
Rickard Strandqvist <rickard.strandqvist@sonymobile.com>,
Jingoo Han <jg1.han@samsung.com>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
David Fries <David@fries.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: uvesafb.c: Cleaning up variable that is never used
Date: Tue, 22 Jul 2014 09:27:57 +0000 [thread overview]
Message-ID: <20140722092757.GA8796@amd.pavel.ucw.cz> (raw)
In-Reply-To: <CAFo99gYhrNR68mdJY=fn1x-+4U=6gdv=C4-Xn-w-YJAPSa5bBQ@mail.gmail.com>
On Tue 2014-07-22 11:16:58, Rickard Strandqvist wrote:
> Hi
>
> Sure, I agree. But as I thought that I would not change
> currentfunctionality, I would increase the chance that the patches were
> included. And it would of course also clarify this type of problem.
I'm trying to say that getting rid of the variables without changing
functionality might be wrong thing to do, for example in this case. It
looks like error handing is missing by mistake, and you are removing
traces saying that error handing is required here.
Dunno. Perhaps don't push patches where solution is not obvious?
Or push them but mark the place with fixme?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-07-22 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 12:51 [PATCH] video: fbdev: uvesafb.c: Cleaning up variable that is never used Rickard Strandqvist
2014-07-06 19:01 ` Rickard Strandqvist
2014-07-21 21:25 ` Pavel Machek
[not found] ` <CAFo99gYhrNR68mdJY=fn1x-+4U=6gdv=C4-Xn-w-YJAPSa5bBQ@mail.gmail.com>
2014-07-22 9:27 ` Pavel Machek [this message]
2014-07-23 20:37 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722092757.GA8796@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=David@fries.net \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rickard.strandqvist@sonymobile.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=sachin.kamat@linaro.org \
--cc=tomi.valkeinen@ti.com \
--cc=udknight@gmail.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).