From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luc Verhaegen Date: Thu, 14 Aug 2014 10:42:08 +0000 Subject: Re: [PATCH 2/4] simplefb: add goto error path to probe Message-Id: <20140814104208.GB1000@skynet.be> List-Id: References: <1407914239-12054-1-git-send-email-libv@skynet.be> <1407914239-12054-3-git-send-email-libv@skynet.be> <20140814102940.GA1000@skynet.be> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Thu, Aug 14, 2014 at 12:33:55PM +0200, David Herrmann wrote: > Hi > > I'd skip the leading whitespace and the newlines, like this: > > +error_unmap: > + iounmap(info->screen_base); > +error_fb_release: > + framebuffer_release(info); > + return ret; > > at least that's my conception how we format error paths in drivers/video/. Will do. Thanks. Luc Verhaegen.