* [PATCH] video: ocfb: Fix data type warning
@ 2014-12-05 8:18 Qiang Chen
2014-12-07 6:08 ` Stefan Kristiansson
2015-01-13 10:49 ` Tomi Valkeinen
0 siblings, 2 replies; 3+ messages in thread
From: Qiang Chen @ 2014-12-05 8:18 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Jingoo Han,
Daniel Vetter, Laurent Pinchart, Stefan Kristiansson
Cc: linux-fbdev, linux-kernel, Qiang Chen
When allocate framebuffer memory using dma_alloc_coherent(),
we'd better use dma_addr_t instead of phys_addr_t. Because the
address we got in fact is DMA or bus address for the platform.
This patch also fixes below build warning:
drivers/video/fbdev/ocfb.c:335:2:
warning: passing argument 3 of ‘dma_alloc_attrs’
from incompatible pointer type [enabled by default]
Signed-off-by: Qiang Chen <qiang2.chen@sonymobile.com>
---
drivers/video/fbdev/ocfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/ocfb.c b/drivers/video/fbdev/ocfb.c
index 7f9dc9b..de98196 100644
--- a/drivers/video/fbdev/ocfb.c
+++ b/drivers/video/fbdev/ocfb.c
@@ -61,7 +61,7 @@ struct ocfb_dev {
/* flag indicating whether the regs are little endian accessed */
int little_endian;
/* Physical and virtual addresses of framebuffer */
- phys_addr_t fb_phys;
+ dma_addr_t fb_phys;
void __iomem *fb_virt;
u32 pseudo_palette[PALETTE_SIZE];
};
--
1.8.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] video: ocfb: Fix data type warning
2014-12-05 8:18 [PATCH] video: ocfb: Fix data type warning Qiang Chen
@ 2014-12-07 6:08 ` Stefan Kristiansson
2015-01-13 10:49 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Kristiansson @ 2014-12-07 6:08 UTC (permalink / raw)
To: Qiang Chen
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Jingoo Han,
Daniel Vetter, Laurent Pinchart, linux-fbdev, linux-kernel,
Qiang Chen
On Fri, Dec 05, 2014 at 04:18:30PM +0800, Qiang Chen wrote:
> When allocate framebuffer memory using dma_alloc_coherent(),
> we'd better use dma_addr_t instead of phys_addr_t. Because the
> address we got in fact is DMA or bus address for the platform.
>
> This patch also fixes below build warning:
> drivers/video/fbdev/ocfb.c:335:2:
> warning: passing argument 3 of ‘dma_alloc_attrs’
> from incompatible pointer type [enabled by default]
>
> Signed-off-by: Qiang Chen <qiang2.chen@sonymobile.com>
Acked-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] video: ocfb: Fix data type warning
2014-12-05 8:18 [PATCH] video: ocfb: Fix data type warning Qiang Chen
2014-12-07 6:08 ` Stefan Kristiansson
@ 2015-01-13 10:49 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2015-01-13 10:49 UTC (permalink / raw)
To: Qiang Chen, Stefan Kristiansson
Cc: Jean-Christophe Plagniol-Villard, Jingoo Han, Daniel Vetter,
Laurent Pinchart, linux-fbdev, linux-kernel, Qiang Chen
[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]
On 05/12/14 10:18, Qiang Chen wrote:
> When allocate framebuffer memory using dma_alloc_coherent(),
> we'd better use dma_addr_t instead of phys_addr_t. Because the
> address we got in fact is DMA or bus address for the platform.
>
> This patch also fixes below build warning:
> drivers/video/fbdev/ocfb.c:335:2:
> warning: passing argument 3 of ‘dma_alloc_attrs’
> from incompatible pointer type [enabled by default]
>
> Signed-off-by: Qiang Chen <qiang2.chen@sonymobile.com>
> ---
> drivers/video/fbdev/ocfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/ocfb.c b/drivers/video/fbdev/ocfb.c
> index 7f9dc9b..de98196 100644
> --- a/drivers/video/fbdev/ocfb.c
> +++ b/drivers/video/fbdev/ocfb.c
> @@ -61,7 +61,7 @@ struct ocfb_dev {
> /* flag indicating whether the regs are little endian accessed */
> int little_endian;
> /* Physical and virtual addresses of framebuffer */
> - phys_addr_t fb_phys;
> + dma_addr_t fb_phys;
> void __iomem *fb_virt;
> u32 pseudo_palette[PALETTE_SIZE];
> };
>
Thanks, queued for 3.20.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-13 10:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-05 8:18 [PATCH] video: ocfb: Fix data type warning Qiang Chen
2014-12-07 6:08 ` Stefan Kristiansson
2015-01-13 10:49 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).