From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] video: vt8500lcdfb: remove unneeded continue
Date: Wed, 07 Jan 2015 04:58:42 +0000 [thread overview]
Message-ID: <20150107044642.GA2543@sudip-PC> (raw)
In-Reply-To: <54AC2A0B.3040807@cogentembedded.com>
On Tue, Jan 06, 2015 at 09:31:39PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 01/06/2015 03:45 PM, Sudip Mukherjee wrote:
>
> >continue is not needed at the end of a for loop
>
> >Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> >---
> > drivers/video/fbdev/vt8500lcdfb.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> >diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c
> >index ffaf29e..6716bf5 100644
> >--- a/drivers/video/fbdev/vt8500lcdfb.c
> >+++ b/drivers/video/fbdev/vt8500lcdfb.c
> >@@ -115,7 +115,6 @@ static int vt8500lcd_set_par(struct fb_info *info)
> > for (i = 0; i < 8; i++) {
> > if (bpp_values[i] = info->var.bits_per_pixel) {
> > reg_bpp = i;
> >- continue;
> > }
>
> {} are not needed any more either. ;-)
i have noticed that but thought that will be again a different type of change in a single patch.
but now it seems that this patch will introduce a new checkpatch warning, so i should have corrected that in it.
i will send a v2.
thanks
sudip
>
> [...]
>
> WBR, Sergei
>
prev parent reply other threads:[~2015-01-07 4:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 12:57 [PATCH] video: vt8500lcdfb: remove unneeded continue Sudip Mukherjee
2015-01-06 12:57 ` [PATCH] fbdev: geocode: remove unneeded NULL check Sudip Mukherjee
2015-01-13 11:31 ` Tomi Valkeinen
2015-01-06 18:31 ` [PATCH] video: vt8500lcdfb: remove unneeded continue Sergei Shtylyov
2015-01-07 4:58 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107044642.GA2543@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).