From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Sun, 18 Jan 2015 12:46:04 +0000 Subject: Re: [PATCH 3/3] backlight: 88pm860x_bl: Use of_get_child_by_name() instead of refcount hack Message-Id: <20150118124604.GU3574@x1> List-Id: References: <1421243519-6257-1-git-send-email-geert+renesas@glider.be> <1421243519-6257-4-git-send-email-geert+renesas@glider.be> In-Reply-To: <1421243519-6257-4-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Geert Uytterhoeven Cc: Benjamin Herrenschmidt , Bryan Wu , Richard Purdie , Jingoo Han , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Wed, 14 Jan 2015, Geert Uytterhoeven wrote: > of_find_node_by_name() calls of_node_put() on its "from" parameter. > To counter this, pm860x_backlight_dt_init() calls of_node_get() first. >=20 > Use of_get_child_by_name() instead to get rid of the refcount hack. >=20 > Signed-off-by: Geert Uytterhoeven > Cc: linux-fbdev@vger.kernel.org > --- > Compile-tested only > --- > drivers/video/backlight/88pm860x_bl.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Looks good, applied, thanks. > diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backli= ght/88pm860x_bl.c > index 9a23698b6fe8398c..2da5862876d1fe78 100644 > --- a/drivers/video/backlight/88pm860x_bl.c > +++ b/drivers/video/backlight/88pm860x_bl.c > @@ -168,10 +168,7 @@ static int pm860x_backlight_dt_init(struct platform_= device *pdev, > struct device_node *nproot, *np; > int iset =3D 0; > =20 > - nproot =3D of_node_get(pdev->dev.parent->of_node); > - if (!nproot) > - return -ENODEV; > - nproot =3D of_find_node_by_name(nproot, "backlights"); > + nproot =3D of_get_child_by_name(pdev->dev.parent->of_node, "backlights"= ); > if (!nproot) { > dev_err(&pdev->dev, "failed to find backlights node\n"); > return -ENODEV; --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog