* [PATCH] staging: sm7xxfb: make smtc_scr_info static
@ 2015-02-03 8:44 Max Perepelitsyn
2015-02-03 14:16 ` Sudip Mukherjee
2015-02-03 17:44 ` Sudip Mukherjee
0 siblings, 2 replies; 4+ messages in thread
From: Max Perepelitsyn @ 2015-02-03 8:44 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh
Cc: linux-fbdev, devel, linux-kernel, Max Perepelitsyn
This symbol is never used anywhere else besides sm7xxfb.c
Signed-off-by: Max Perepelitsyn <mperepelitsyn@gmail.com>
---
drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index 2ae9fd0..72036c2 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -111,7 +111,7 @@ static struct vesa_mode vesa_mode_table[] = {
{"0x31B", 1280, 1024, 24},
};
-struct screen_info smtc_scr_info;
+static struct screen_info smtc_scr_info;
/* process command line options, get vga parameter */
static int __init sm7xx_vga_setup(char *options)
--
2.2.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: sm7xxfb: make smtc_scr_info static
2015-02-03 8:44 [PATCH] staging: sm7xxfb: make smtc_scr_info static Max Perepelitsyn
@ 2015-02-03 14:16 ` Sudip Mukherjee
2015-02-03 15:38 ` Greg KH
2015-02-03 17:44 ` Sudip Mukherjee
1 sibling, 1 reply; 4+ messages in thread
From: Sudip Mukherjee @ 2015-02-03 14:16 UTC (permalink / raw)
To: Max Perepelitsyn; +Cc: teddy.wang, gregkh, linux-fbdev, devel, linux-kernel
On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote:
> This symbol is never used anywhere else besides sm7xxfb.c
Hi Greg,
do i need to do anything about this patch? maybe a tested-by or reviewed-by?
regards
sudip
>
> Signed-off-by: Max Perepelitsyn <mperepelitsyn@gmail.com>
> ---
> drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
> index 2ae9fd0..72036c2 100644
> --- a/drivers/staging/sm7xxfb/sm7xxfb.c
> +++ b/drivers/staging/sm7xxfb/sm7xxfb.c
> @@ -111,7 +111,7 @@ static struct vesa_mode vesa_mode_table[] = {
> {"0x31B", 1280, 1024, 24},
> };
>
> -struct screen_info smtc_scr_info;
> +static struct screen_info smtc_scr_info;
>
> /* process command line options, get vga parameter */
> static int __init sm7xx_vga_setup(char *options)
> --
> 2.2.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: sm7xxfb: make smtc_scr_info static
2015-02-03 14:16 ` Sudip Mukherjee
@ 2015-02-03 15:38 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2015-02-03 15:38 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Max Perepelitsyn, devel, linux-fbdev, teddy.wang, linux-kernel
On Tue, Feb 03, 2015 at 07:34:01PM +0530, Sudip Mukherjee wrote:
> On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote:
> > This symbol is never used anywhere else besides sm7xxfb.c
>
> Hi Greg,
> do i need to do anything about this patch? maybe a tested-by or reviewed-by?
If you test or review it, yes, please add such a line to an email and
reply to the patch with it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: sm7xxfb: make smtc_scr_info static
2015-02-03 8:44 [PATCH] staging: sm7xxfb: make smtc_scr_info static Max Perepelitsyn
2015-02-03 14:16 ` Sudip Mukherjee
@ 2015-02-03 17:44 ` Sudip Mukherjee
1 sibling, 0 replies; 4+ messages in thread
From: Sudip Mukherjee @ 2015-02-03 17:44 UTC (permalink / raw)
To: Max Perepelitsyn; +Cc: teddy.wang, gregkh, linux-fbdev, devel, linux-kernel
On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote:
> This symbol is never used anywhere else besides sm7xxfb.c
>
> Signed-off-by: Max Perepelitsyn <mperepelitsyn@gmail.com>
Tested-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
> index 2ae9fd0..72036c2 100644
> --- a/drivers/staging/sm7xxfb/sm7xxfb.c
> +++ b/drivers/staging/sm7xxfb/sm7xxfb.c
> @@ -111,7 +111,7 @@ static struct vesa_mode vesa_mode_table[] = {
> {"0x31B", 1280, 1024, 24},
> };
>
> -struct screen_info smtc_scr_info;
> +static struct screen_info smtc_scr_info;
>
> /* process command line options, get vga parameter */
> static int __init sm7xx_vga_setup(char *options)
> --
> 2.2.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-03 17:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-03 8:44 [PATCH] staging: sm7xxfb: make smtc_scr_info static Max Perepelitsyn
2015-02-03 14:16 ` Sudip Mukherjee
2015-02-03 15:38 ` Greg KH
2015-02-03 17:44 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).