From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Joe Perches <joe@perches.com>
Cc: Parmeshwr Prasad <parmeshwr_prasad@dell.com>,
plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, trivial@kernel.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2]Trivial patch: to solve indentation warnings in amba-clcd.c driver
Date: Fri, 13 Feb 2015 12:03:19 +0000 [thread overview]
Message-ID: <20150213120319.GX8656@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1423828796.2795.7.camel@perches.com>
On Fri, Feb 13, 2015 at 03:59:56AM -0800, Joe Perches wrote:
> Perhaps this could be better as:
>
> fb->fb.fix.smem_start > of_translate_address(memory,
> of_get_address(memory, 0, &size, NULL));
>
> But sometimes using multiple statements instead of
> embedding function calls as arguments can be simpler
> and more intelligible for the reader.
>
> __be32 addr;
>
> ...
>
> addr = of_get_address(memory, 0, &size, NULL);
> fb->fb.fix.smem_start = of_translate_address(memory, addr);
Yes, that would be a better solution, thanks.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-02-13 12:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 11:21 [PATCH 1/2]Trivial patch: to solve indentation warnings in amba-clcd.c driver Parmeshwr Prasad
2015-02-13 11:35 ` Russell King - ARM Linux
2015-02-13 11:59 ` Joe Perches
2015-02-13 12:03 ` Russell King - ARM Linux [this message]
2015-02-13 13:28 ` [PATCH 2/2]Trivial " Parmeshwr Prasad
2015-02-13 13:36 ` Russell King - ARM Linux
2015-02-14 10:20 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150213120319.GX8656@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=joe@perches.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parmeshwr_prasad@dell.com \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).