From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicholas Mc Guire Date: Fri, 20 Feb 2015 14:20:06 +0000 Subject: Re: [PATCH] video: fbdev: use msecs_to_jiffies for time conversion Message-Id: <20150220142006.GA11757@opentech.at> List-Id: References: <1423214041-15818-1-git-send-email-hofrat@osadl.org> <54E72774.1070809@ti.com> <20150220140110.GA25767@opentech.at> <54E73F78.3050009@ti.com> In-Reply-To: <54E73F78.3050009@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: Nicholas Mc Guire , Jean-Christophe Plagniol-Villard , Jingoo Han , Daniel Vetter , Fabian Frederick , Laurent Pinchart , Wolfram Sang , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, 20 Feb 2015, Tomi Valkeinen wrote: > On 20/02/15 16:01, Nicholas Mc Guire wrote: > > >>> pr_debug("%s(): task ending\n", __func__); > >>> @@ -1460,7 +1460,7 @@ static void pxafb_disable_controller(struct pxafb_info *fbi) > >>> #ifdef CONFIG_FB_PXA_SMARTPANEL > >>> if (fbi->lccr0 & LCCR0_LCDT) { > >>> wait_for_completion_timeout(&fbi->refresh_done, > >>> - 200 * HZ / 1000); > >>> + msecs_to_jiffies(200); > >> > >> That will not compile. > > > No compile warning or errors > > > > could you send me the compile error message and the toolchain you > > are using - this change should not really have any noticable impact. > > I didn't compile it. It's missing a closing parenthesis. > > This is one reason I'm not very fond of cleanups to drivers that the > patch sender cannot test... They may cause more problems than they help. > That was the intent of compile testing the patch but it seems that it was not covered by the config in use - sorry for that, it was missing the [*] PXA Smartpanel LCD support so root@debian:~/linux-next# grep CONFIG_FB_PXA_SMARTPANEL .config # CONFIG_FB_PXA_SMARTPANEL is not set The motivation for the cleanup simply was code reasdability - will fix this up and compile check with a proper config. thx! hofrat