* [PATCH 3/3] Moved assignment out of if() statement in efifb.c
@ 2015-02-18 8:36 Parmeshwr Prasad
2015-02-26 10:48 ` Parmeshwr Prasad
0 siblings, 1 reply; 2+ messages in thread
From: Parmeshwr Prasad @ 2015-02-18 8:36 UTC (permalink / raw)
To: pjones, plagnioj, tomi.valkeinen; +Cc: linux-fbdev, linux-kernel
This patch depend on my earlier patchs.
Moving assignment out of if() statement.
Signed-off-by: Parmeshwr Prasad <parmeshwr_prasad@dell.com>
---
drivers/video/fbdev/efifb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index cc1a156..9124ba9 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -275,11 +275,13 @@ static int efifb_probe(struct platform_device *dev)
info->fix = efifb_fix;
info->flags = FBINFO_FLAG_DEFAULT | FBINFO_MISC_FIRMWARE;
- if ((err = fb_alloc_cmap(&info->cmap, 256, 0)) < 0) {
+ err = fb_alloc_cmap(&info->cmap, 256, 0);
+ if (err < 0) {
pr_err("efifb: cannot allocate colormap\n");
goto err_unmap;
}
- if ((err = register_framebuffer(info)) < 0) {
+ err = register_framebuffer(info);
+ if (err < 0) {
pr_err("efifb: cannot register framebuffer\n");
goto err_fb_dealoc;
}
--
1.9.3
-Parmeshwr
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH 3/3] Moved assignment out of if() statement in efifb.c
2015-02-18 8:36 [PATCH 3/3] Moved assignment out of if() statement in efifb.c Parmeshwr Prasad
@ 2015-02-26 10:48 ` Parmeshwr Prasad
0 siblings, 0 replies; 2+ messages in thread
From: Parmeshwr Prasad @ 2015-02-26 10:48 UTC (permalink / raw)
To: pjones-H+wXaHxf7aLQT0dZR+AlfA
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA,
plagnioj-sclMFOaUSTBWk0Htik3J/w
Removing initialization out of if condition.
Signed-off-by: Parmeshwr Prasad <parmeshwr_prasad@dell.com>
---
drivers/video/fbdev/efifb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index cc1a156..9124ba9 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -275,11 +275,13 @@ static int efifb_probe(struct platform_device *dev)
info->fix = efifb_fix;
info->flags = FBINFO_FLAG_DEFAULT | FBINFO_MISC_FIRMWARE;
- if ((err = fb_alloc_cmap(&info->cmap, 256, 0)) < 0) {
+ err = fb_alloc_cmap(&info->cmap, 256, 0);
+ if (err < 0) {
pr_err("efifb: cannot allocate colormap\n");
goto err_unmap;
}
- if ((err = register_framebuffer(info)) < 0) {
+ err = register_framebuffer(info);
+ if (err < 0) {
pr_err("efifb: cannot register framebuffer\n");
goto err_fb_dealoc;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-26 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-18 8:36 [PATCH 3/3] Moved assignment out of if() statement in efifb.c Parmeshwr Prasad
2015-02-26 10:48 ` Parmeshwr Prasad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).