* [PATCH] staging/sm7xxfb: Make 'struct vgamode' static
@ 2015-02-23 11:16 Peter Senna Tschudin
2015-02-24 5:58 ` Sudip Mukherjee
2015-03-07 0:36 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Peter Senna Tschudin @ 2015-02-23 11:16 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel,
linux-kernel
Cc: Peter Senna Tschudin
sparse was complaining that symbol 'vgamode' was not declared.
Declaring vgamode as static.
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
Tested by compilation only
drivers/staging/sm7xxfb/sm7xx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h
index 7cc1896..c5d6253 100644
--- a/drivers/staging/sm7xxfb/sm7xx.h
+++ b/drivers/staging/sm7xxfb/sm7xx.h
@@ -119,7 +119,7 @@ struct ModeInit {
/**********************************************************************
SM712 Mode table.
**********************************************************************/
-struct ModeInit vgamode[] = {
+static struct ModeInit vgamode[] = {
{
/* mode#0: 640 x 480 16Bpp 60Hz */
640, 480, 16, 60,
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging/sm7xxfb: Make 'struct vgamode' static
2015-02-23 11:16 [PATCH] staging/sm7xxfb: Make 'struct vgamode' static Peter Senna Tschudin
@ 2015-02-24 5:58 ` Sudip Mukherjee
2015-03-07 0:36 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-02-24 5:58 UTC (permalink / raw)
To: Peter Senna Tschudin; +Cc: teddy.wang, gregkh, linux-fbdev, devel, linux-kernel
On Mon, Feb 23, 2015 at 12:16:16PM +0100, Peter Senna Tschudin wrote:
> sparse was complaining that symbol 'vgamode' was not declared.
>
> Declaring vgamode as static.
a similar patch has already been sent to Greg, which is not yet applied.
regards
sudip
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging/sm7xxfb: Make 'struct vgamode' static
2015-02-23 11:16 [PATCH] staging/sm7xxfb: Make 'struct vgamode' static Peter Senna Tschudin
2015-02-24 5:58 ` Sudip Mukherjee
@ 2015-03-07 0:36 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-03-07 0:36 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, devel, linux-kernel
On Mon, Feb 23, 2015 at 12:16:16PM +0100, Peter Senna Tschudin wrote:
> sparse was complaining that symbol 'vgamode' was not declared.
>
> Declaring vgamode as static.
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> Tested by compilation only
>
> drivers/staging/sm7xxfb/sm7xx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
As was mentioned, someone sent this before you did, sorry.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-07 0:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-23 11:16 [PATCH] staging/sm7xxfb: Make 'struct vgamode' static Peter Senna Tschudin
2015-02-24 5:58 ` Sudip Mukherjee
2015-03-07 0:36 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).