From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LFBDEV <linux-fbdev@vger.kernel.org>,
OSUOSL Drivers <devel@driverdev.osuosl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] staging: sm750fb: wrong type for print
Date: Mon, 09 Mar 2015 08:42:20 +0000 [thread overview]
Message-ID: <20150309082956.GA9059@sudip-PC> (raw)
In-Reply-To: <CA+V-a8s65fCvd2cA6w2EwaJfaLgPqQ=Hme+m9_wv+y3Y=GxPiQ@mail.gmail.com>
On Mon, Mar 09, 2015 at 07:42:53AM +0000, Lad, Prabhakar wrote:
> On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> >
> >
> > this patch will give checkpatch warnings about use of printk.
> > this patch was mainly to fix the build warnings. printk will be
> > converted to pr_* and dev_* in a later patch.
> >
> > + printk("lynxfb mmap pgoff: %lx\n", vma->vm_pgoff);
> > + printk("lynxfb mmap off 1: %lx\n", off);
> >
> wouldn't it makes sense to change printk to some pr_*() ?
yes, i could have. But usually Greg does not accept patches which is doing more than one type of change. That is why I mentioned in the comments that this will be converted to pr_* and dev_* in a later patch.
regards
sudip
>
> Cheers,
> --Prabhakar Lad
next prev parent reply other threads:[~2015-03-09 8:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 7:47 [PATCH v2 1/4] staging: sm750fb: wrong type for print Sudip Mukherjee
2015-03-09 7:42 ` Lad, Prabhakar
2015-03-09 8:42 ` Sudip Mukherjee [this message]
2015-03-09 7:47 ` [PATCH v2 2/4] staging: sm750fb: remove pragma optimize Sudip Mukherjee
2015-03-09 7:47 ` [PATCH v2 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID Sudip Mukherjee
2015-03-09 7:47 ` Lad, Prabhakar
2015-03-09 8:53 ` Sudip Mukherjee
2015-03-09 7:47 ` [PATCH v2 4/4] staging: sm750fb: fix undeclared function Sudip Mukherjee
2015-03-09 12:42 ` Dan Carpenter
2015-03-09 12:55 ` Sudip Mukherjee
2015-03-09 13:29 ` Dan Carpenter
2015-03-09 11:53 ` [PATCH v2 1/4] staging: sm750fb: wrong type for print Dan Carpenter
2015-03-09 12:23 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309082956.GA9059@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).