From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: sm7xxfb: change return of sm7xx_vga_setup
Date: Wed, 11 Mar 2015 08:59:45 +0000 [thread overview]
Message-ID: <20150311085931.GB4560@sudip-PC> (raw)
In-Reply-To: <20150309140414.GA11015@mwanda>
On Mon, Mar 09, 2015 at 05:04:14PM +0300, Dan Carpenter wrote:
> On Mon, Mar 09, 2015 at 07:23:43PM +0530, Sudip Mukherjee wrote:
<snip>
> > > Hm... That's a good question.
> > >
> > > I suspect we should just go with fb_get_mode() and do it quickly. This
> > > driver is so new in the kernel that there are no users to get upset.
> >
> > i am afraid that is not correct. this driver was in staging from long
> > back, and Greg removed it from staging as no one was working with it.
> > But after that removal Lemote Yeeloong laptop of Steven Rostedt
> > stopped working. (https://lkml.org/lkml/2014/11/20/698) , so i guess
> > there will be many such users.
>
> Hm... I suspect we should still change it so it matches the other FB
> drivers but I don't know.
>
> Perhaps Greg has an opinion?
maybe, i should make the change and then we can request Steven Rostedt
to test it on his Lemote Yeeloong. if nothing breaks, then alright,
else revert the patch.
regards
sudip
>
> regards,
> dan carpenter
>
prev parent reply other threads:[~2015-03-11 8:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 17:52 [PATCH 1/3] staging: sm7xxfb: use module init and exit Sudip Mukherjee
2015-03-08 17:52 ` [PATCH 2/3] staging: sm7xxfb: remove unneeded __setup Sudip Mukherjee
2015-03-08 17:52 ` [PATCH 3/3] staging: sm7xxfb: change return of sm7xx_vga_setup Sudip Mukherjee
2015-03-09 13:13 ` Dan Carpenter
2015-03-09 13:42 ` Sudip Mukherjee
2015-03-09 13:38 ` Dan Carpenter
2015-03-09 13:53 ` Sudip Mukherjee
2015-03-09 14:04 ` Dan Carpenter
2015-03-11 8:59 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311085931.GB4560@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).