* Re: [PATCH] staging: sm750fb: braces, indents, spaces fix
[not found] <20150313051436.GA10544@localhost.localdomain>
@ 2015-03-13 5:54 ` Sudip Mukherjee
0 siblings, 0 replies; 6+ messages in thread
From: Sudip Mukherjee @ 2015-03-13 5:54 UTC (permalink / raw)
To: Ragavendra BN; +Cc: gregkh, linux-fbdev, devel, linux-kernel
On Thu, Mar 12, 2015 at 10:14:36PM -0700, Ragavendra BN wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checpath.pl script check.
your From: is still having [user] in your email address.
and you are doing too many things in a single patch. one patch should
do only one type of change.
>
>
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
>
this extra blank line is not necessary here.
regards
sudip
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: sm750fb: braces, indents, spaces fix
@ 2015-03-13 3:43 Ragavendra BN
2015-03-13 4:58 ` Sudip Mukherjee
2015-03-13 6:11 ` Ragavendra BN
0 siblings, 2 replies; 6+ messages in thread
From: Ragavendra BN @ 2015-03-13 3:43 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel,
linux-kernel
Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the code give no
warnings by the checkpath.pl script check.
---
drivers/staging/sm750fb/ddk750_chip.c | 22 ++++++++--------------
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index b71169e..041a05a 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -20,22 +20,16 @@ logical_chip_type_t getChipType()
physicalID = devId750;//either 0x718 or 0x750
physicalRev = revId750;
- if (physicalID = 0x718)
- {
- chip = SM718;
- }
- else if (physicalID = 0x750)
- {
- chip = SM750;
+ if (physicalID = 0x718) {
+ chip = SM718;
+ } else if (physicalID = 0x750) {
+ chip = SM750;
/* SM750 and SM750LE are different in their revision ID only. */
- if (physicalRev = SM750LE_REVISION_ID){
+ if (physicalRev = SM750LE_REVISION_ID)
chip = SM750LE;
- }
- }
- else
- {
- chip = SM_UNKNOWN;
- }
+ } else {
+ chip = SM_UNKNOWN;
+ }
return chip;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: sm750fb: braces, indents, spaces fix
2015-03-13 3:43 Ragavendra BN
@ 2015-03-13 4:58 ` Sudip Mukherjee
2015-03-13 6:11 ` Ragavendra BN
1 sibling, 0 replies; 6+ messages in thread
From: Sudip Mukherjee @ 2015-03-13 4:58 UTC (permalink / raw)
To: Ragavendra BN; +Cc: teddy.wang, gregkh, linux-fbdev, devel, linux-kernel
On Thu, Mar 12, 2015 at 08:43:33PM -0700, Ragavendra BN wrote:
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
>
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checkpath.pl script check.
>
Signed-off-by line should come here before the ---
> ---
not at the top like you are giving.
Greg has told you once, I am telling now for the second time.
regards
sudip
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: sm750fb: braces, indents, spaces fix
2015-03-13 3:43 Ragavendra BN
2015-03-13 4:58 ` Sudip Mukherjee
@ 2015-03-13 6:11 ` Ragavendra BN
2015-03-13 7:45 ` Dan Carpenter
1 sibling, 1 reply; 6+ messages in thread
From: Ragavendra BN @ 2015-03-13 6:11 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel,
linux-kernel
This patch removes the braces for the single line if statement. It fixes
the indent positions correctly. It fixes the spaces appropriately making the code give no
warnings by the checpath.pl script check. Please accept.
Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 22 ++++++++--------------
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index b71169e..041a05a 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -20,22 +20,16 @@ logical_chip_type_t getChipType()
physicalID = devId750;//either 0x718 or 0x750
physicalRev = revId750;
- if (physicalID = 0x718)
- {
- chip = SM718;
- }
- else if (physicalID = 0x750)
- {
- chip = SM750;
+ if (physicalID = 0x718) {
+ chip = SM718;
+ } else if (physicalID = 0x750) {
+ chip = SM750;
/* SM750 and SM750LE are different in their revision ID only. */
- if (physicalRev = SM750LE_REVISION_ID){
+ if (physicalRev = SM750LE_REVISION_ID)
chip = SM750LE;
- }
- }
- else
- {
- chip = SM_UNKNOWN;
- }
+ } else {
+ chip = SM_UNKNOWN;
+ }
return chip;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: sm750fb: braces, indents, spaces fix
2015-03-13 6:11 ` Ragavendra BN
@ 2015-03-13 7:45 ` Dan Carpenter
[not found] ` <CAPBgb4=np7Bs=sMTZHpZZ1Ef7uriUDYjjz6Y7+49Vs1rOVo59w@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2015-03-13 7:45 UTC (permalink / raw)
To: Ragavendra BN
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel,
linux-kernel
On Thu, Mar 12, 2015 at 11:11:27PM -0700, Ragavendra BN wrote:
> This patch removes the braces for the single line if statement. It fixes
> the indent positions correctly. It fixes the spaces appropriately making the code give no
> warnings by the checpath.pl script check. Please accept.
^^^^^^^^^^^^^^
Don't put this in the changelog.
>
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com>
Is your name *really* BN?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-14 8:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150313051436.GA10544@localhost.localdomain>
2015-03-13 5:54 ` [PATCH] staging: sm750fb: braces, indents, spaces fix Sudip Mukherjee
2015-03-13 3:43 Ragavendra BN
2015-03-13 4:58 ` Sudip Mukherjee
2015-03-13 6:11 ` Ragavendra BN
2015-03-13 7:45 ` Dan Carpenter
[not found] ` <CAPBgb4=np7Bs=sMTZHpZZ1Ef7uriUDYjjz6Y7+49Vs1rOVo59w@mail.gmail.com>
2015-03-14 8:39 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).