From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michel von Czettritz <michel.von.czettritz@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: fixing multiple checkpatch errors and warnings
Date: Thu, 19 Mar 2015 20:21:24 +0000 [thread overview]
Message-ID: <20150319202124.GW10964@mwanda> (raw)
In-Reply-To: <20150319192603.GA26974@x230-arch.club.entropia.de>
On Thu, Mar 19, 2015 at 08:26:03PM +0100, Michel von Czettritz wrote:
> This patch formats sm750.c to
> - correct intendations
> - no leading or trailing whitespaces
> - no C99 Style comments
> - correct braces and spacings for if, for and functions
> - no initalisation of static variables to 0 or NULL
> - no assignments in if conditions
> - correct spacings arround pointers and function arguments
>
> and some other warnings
This patch does too many things at once. Split it up into one type of
warning per patch.
regards,
dan carpenter
prev parent reply other threads:[~2015-03-19 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 19:26 [PATCH] staging: sm750fb: fixing multiple checkpatch errors and warnings Michel von Czettritz
2015-03-19 20:21 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319202124.GW10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michel.von.czettritz@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).